Closed Bug 1265401 Opened 7 years ago Closed 7 years ago

Perform linear interpolation when computing the SetValueCurveAtTime events

Categories

(Core :: Web Audio, defect, P2)

Product:
Core
Component:
Web Audio
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: padenot, Assigned: dminor)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Bug 1265401 - Perform linear interpolation when computing the SetValueCurveAtTime events;
58 bytes, text/x-review-board-request
padenot
: review+
Details 
We used to just sample the curve, but the working group has agreed on linear interpolation.

Spec changes at https://github.com/webaudio/web-audio-api/commit/b6acfabccbd60f704c4e98101ddfef39eb987acf.
Priority: -- → P2
Rank: 25
Depends on: 1184057
Wasted at least 30 minutes this morning wondering why the values weren't being interpolated in my test case, so I'm going to fix this one now.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Comment on attachment 8803958 [details]
Bug 1265401 - Perform linear interpolation when computing the SetValueCurveAtTime events;

https://reviewboard.mozilla.org/r/88142/#review87368
Attachment #8803958 - Flags: review?(padenot) → review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64293caeec1e
Perform linear interpolation when computing the SetValueCurveAtTime events; r=padenot
https://hg.mozilla.org/mozilla-central/rev/64293caeec1e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Depends on: 1313058
Blocks: 1228207
No longer blocks: 1228207
You need to log in before you can comment on or make changes to this bug.