Closed
Bug 1265449
Opened 8 years ago
Closed 8 years ago
SIMD.js: remove a static assumption about SIMD representation
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bbouvier, Unassigned)
Details
Attachments
(1 file)
1.11 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This static assertion mentions InternalHandle although they're not used anymore around here and don't seem to exist at all. Jon, setting you as reviewer because I seem to recall you reviewed the change that introduced this static_assert.
Attachment #8742418 -
Flags: review?(jcoppeard)
Comment 1•8 years ago
|
||
Comment on attachment 8742418 [details] [diff] [review] staticassertion.patch Review of attachment 8742418 [details] [diff] [review]: ----------------------------------------------------------------- Not sure I remember why that was needed, but it looks good without. We should probably assert that the typed object is large enough in FillLanes above though.
Attachment #8742418 -
Flags: review?(jcoppeard) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/22d56f931cb6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•