SIMD.js: remove a static assumption about SIMD representation

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bbouvier, Unassigned)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

This static assertion mentions InternalHandle although they're not used anymore around here and don't seem to exist at all. Jon, setting you as reviewer because I seem to recall you reviewed the change that introduced this static_assert.
Attachment #8742418 - Flags: review?(jcoppeard)
Comment on attachment 8742418 [details] [diff] [review]
staticassertion.patch

Review of attachment 8742418 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure I remember why that was needed, but it looks good without.

We should probably assert that the typed object is large enough in FillLanes above though.
Attachment #8742418 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/22d56f931cb6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.