Closed Bug 1265495 Opened 8 years ago Closed 7 years ago

Technical and Editorial reviews should never trigger spam filters

Categories

(developer.mozilla.org Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: shobson, Unassigned)

References

Details

(Keywords: in-triage)

Expected behaviour:
1) click edit
2) check both boxes under "Review needed?"
3) publish
4) never ever get caught by the spam filters.

What happened:
I got caught by the spam filters on my local dev :(

Other info:
I am working on an old branch, it is possible stuff has already been done to prevent this.
Why should this skip the spam filters?
If the only user input is to check or uncheck a box there are no opportunities for spam.
OK, I understand now - the only change is to set the review flags.  It should be better after bug 1259173 / PR #3835 [1], but testing is needed.

[1] https://github.com/mozilla/kuma/pull/3835
Just an information here: there are 2 ways to perform these actions: one on the reader view (and in this case we are sure that the reviews are the only actions), one on the editor view (and in this case the reviews may be combined with editing actions).
Still, if the text doesn't change, the spam filter shouldn't be run.
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/108699cf88925bee0de8bc830ef2f3ce842c4424
fix bug 1265495: Skip spam check for some edits

If an edit does not change the content (such as settings or clearing the
review requested flags), then do not submit the edit to Akismet to check
for spam.

https://github.com/mozilla/kuma/commit/230b814dab510a8da7848a1e685d17cb2cfc85f9
Merge pull request #4184 from jwhitlock/no_akismet_review_1265495

fix bug 1265495: Skip spam check for some edits
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
If there are no content changes detected, then the change is no longer sent to Akismet for spam checking.  However, the page content is not normalized, so some insignificant changes such as whitespace and indenting changes by CKEditor can appear as content changes, triggering an Akismet check.  The solution is to normalize the content, which will require some additional changes tracked in bug 1358541
See Also: → 1358541
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.