Closed
Bug 1265496
Opened 8 years ago
Closed 8 years ago
Rename adapter* strings in aboutSupport.properties (about:support) to reflect updated text
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: flod, Assigned: dvander)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
3.62 KB,
patch
|
milan
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/diff/efaa8959220e/toolkit/locales/en-US/chrome/global/aboutSupport.properties A few strings changed in this landing without a new ID -adapterDescription = Adapter Description +adapterDescription = Description -adapterDrivers = Adapter Drivers +adapterDrivers = Drivers -adapterRAM = Adapter RAM +adapterRAM = RAM The only way to ensure these changes are picked up by localization is to use different IDs. https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings Using adapterDescription2, adapterDrivers2, and adapterRAM2 would work.
Given that we have potentially two GPUs and thus two different versions of "2" is probably not the best thing to use, but something like newAdapterDescription, etc. should work :) Let's see if we can do it this week before the trains change.
Assignee: nobody → dvander
Whiteboard: [gfx-noted]
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8743019 -
Flags: review?(milan)
Comment on attachment 8743019 [details] [diff] [review] patch Review of attachment 8743019 [details] [diff] [review]: ----------------------------------------------------------------- Crash reports will still get the "adapter...", right?
Attachment #8743019 -
Flags: review?(milan) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Yeah, nsIGfxInfo and friends aren't changing, just the language strings.
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/27b5119d82e0
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•