1265579 - updates builder fails if RC doesn't contain release versions

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

RC with partials set to 46.0b10build1, 46.0b11build1, 46.0b9build1 fails:

16:09:41     INFO - Running main action method: bump_configs
16:09:41    FATAL - Uncaught exception: Traceback (most recent call last):
16:09:41    FATAL -   File "/builds/slave/rel-m-rel-fx_upds-000000000000/scripts/mozharness/base/script.py", line 1765, in run
16:09:41    FATAL -     self.run_action(action)
16:09:41    FATAL -   File "/builds/slave/rel-m-rel-fx_upds-000000000000/scripts/mozharness/base/script.py", line 1707, in run_action
16:09:41    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
16:09:41    FATAL -   File "/builds/slave/rel-m-rel-fx_upds-000000000000/scripts/mozharness/base/script.py", line 1647, in _possibly_run_method
16:09:41    FATAL -     return getattr(self, method_name)()
16:09:41    FATAL -   File "scripts/scripts/release/updates.py", line 167, in bump_configs
16:09:41    FATAL -     self.bump_patcher_config(channel_config)
16:09:41    FATAL -   File "scripts/scripts/release/updates.py", line 206, in bump_patcher_config
16:09:41    FATAL -     self.config["version"], partial_versions),
16:09:41    FATAL -   File "/builds/slave/rel-m-rel-fx_upds-000000000000/scripts/mozharness/mozilla/release.py", line 70, in get_previous_version
16:09:41    FATAL -     return composed[0][0]
16:09:41    FATAL - IndexError: list index out of range
16:09:41    FATAL - Running post_fatal callback...
16:09:41    FATAL - Exiting -1
16:09:41     INFO - Running post-run listener: copy_logs_to_upload_dir
16:09:41     INFO - Copying logs to upload dir...
16:09:41     INFO - mkdir: /builds/slave/rel-m-rel-fx_upds-000000000000/build/upload/logs

Comment 1

[Rail Aliiev [:rail]]

The same applies for RC without beta version in partials :/

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Will take care of this as part of the release sanity process that I'm currently having under way.

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1265579 - Improve relpro sanity with RC partials testcase.

Review commit: https://reviewboard.mozilla.org/r/65296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65296/

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8772505 [details]
Bug 1265579 - Improve relpro sanity with RC partials testcase.

https://reviewboard.mozilla.org/r/65296/#review62326

::: lib/python/kickoff/sanity.py:288
(Diff revision 1)
> +        ret = [matches(name, BETA_PATTERNS) for name in self.partial_updates]
> +        at_least_one_beta = any(ret)
> +        all_betas = all(ret) and ret != []
> +
> +        partials = ["{name}".format(name=p) for p in self.partial_updates]
> +        err_msg = "No beta found in the RC list of partials:{l}".format(l=partials)

A nit, can you add a space after :

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8772505 [details]
Bug 1265579 - Improve relpro sanity with RC partials testcase.

http://hg.mozilla.org/build/tools/rev/9fffec773c7b

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

This is done now - will leave the bug open until we ship the 48.0 RC in a couple of weeks to make sure everything is OK.

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

Traceback (most recent call last):
  File "release-runner.py", line 401, in main
    validate_graph_kwargs(queue, gpg_key_path, **kwargs)
  File "release-runner.py", line 222, in validate_graph_kwargs
    raise SanityException("Issues on release sanity %s" % errors)
SanityException: Issues on release sanity

* No beta found in the RC list of partials: ['47.0', '47.0.1', '46.0.1', '45.0.2']:
Result of assertion, no exception stacktrace available

Closing this bug, worked as expected during 48.0 RC.
Will reopen if issues come by.