1265591 - rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Both heycam and I were confused last week by ReconstructStyleData, which we sometimes think is RebuildAllStyleData.  We should rename it to something less confusing.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: MozReview Request: Bug 1265591 patch 1 - Remove Internal/External versions of ReconstructStyleData. r?heycam

This Internal/External difference was added in bug 253889 in the year
2004, when we build layout as a library separate from things like
editor.  It is no longer needed now that we have libxul, and should not
be used by any external callers.

Review commit: https://reviewboard.mozilla.org/r/47357/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47357/

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: MozReview Request: Bug 1265591 patch 2 - Rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges. r?heycam

Review commit: https://reviewboard.mozilla.org/r/47359/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47359/

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: MozReview Request: Bug 1265591 patch 3 - Make the comment describing RestyleForCSSRuleChanges match reality. r?heycam

Review commit: https://reviewboard.mozilla.org/r/47361/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47361/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8742611 [details]
MozReview Request: Bug 1265591 patch 1 - Remove Internal/External versions of ReconstructStyleData.  r?heycam

https://reviewboard.mozilla.org/r/47357/#review44051

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8742612 [details]
MozReview Request: Bug 1265591 patch 2 - Rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges.  r?heycam

https://reviewboard.mozilla.org/r/47359/#review44053

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8742612 [details]
MozReview Request: Bug 1265591 patch 2 - Rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges.  r?heycam

https://reviewboard.mozilla.org/r/47359/#review44055

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8742613 [details]
MozReview Request: Bug 1265591 patch 3 - Make the comment describing RestyleForCSSRuleChanges match reality.  r?heycam

https://reviewboard.mozilla.org/r/47361/#review44049

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/396260a4b86bb00b044b07487ca2af55fca52425
Bug 1265591 patch 1 - Remove Internal/External versions of ReconstructStyleData.  r=heycam

https://hg.mozilla.org/integration/mozilla-inbound/rev/f411f50ad23b194b570f2e30fe6b06b8881b183f
Bug 1265591 patch 2 - Rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges.  r=heycam

https://hg.mozilla.org/integration/mozilla-inbound/rev/aea48706d499202a9d2b9b6bfd2292cc08fe1535
Bug 1265591 patch 3 - Make the comment describing RestyleForCSSRuleChanges match reality.  r=heycam

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/396260a4b86b
https://hg.mozilla.org/mozilla-central/rev/f411f50ad23b
https://hg.mozilla.org/mozilla-central/rev/aea48706d499