Closed Bug 1265591 Opened 8 years ago Closed 8 years ago

rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(3 files)

Both heycam and I were confused last week by ReconstructStyleData, which we sometimes think is RebuildAllStyleData.  We should rename it to something less confusing.
This Internal/External difference was added in bug 253889 in the year
2004, when we build layout as a library separate from things like
editor.  It is no longer needed now that we have libxul, and should not
be used by any external callers.

Review commit: https://reviewboard.mozilla.org/r/47357/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47357/
Attachment #8742611 - Flags: review?(cam)
Attachment #8742612 - Flags: review?(cam)
Attachment #8742613 - Flags: review?(cam)
Attachment #8742611 - Flags: review?(cam) → review+
Comment on attachment 8742611 [details]
MozReview Request: Bug 1265591 patch 1 - Remove Internal/External versions of ReconstructStyleData.  r?heycam

https://reviewboard.mozilla.org/r/47357/#review44051
Attachment #8742612 - Flags: review?(cam)
Comment on attachment 8742612 [details]
MozReview Request: Bug 1265591 patch 2 - Rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges.  r?heycam

https://reviewboard.mozilla.org/r/47359/#review44053
Comment on attachment 8742612 [details]
MozReview Request: Bug 1265591 patch 2 - Rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges.  r?heycam

https://reviewboard.mozilla.org/r/47359/#review44055
Attachment #8742612 - Flags: review+
Comment on attachment 8742613 [details]
MozReview Request: Bug 1265591 patch 3 - Make the comment describing RestyleForCSSRuleChanges match reality.  r?heycam

https://reviewboard.mozilla.org/r/47361/#review44049
Attachment #8742613 - Flags: review?(cam) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/396260a4b86bb00b044b07487ca2af55fca52425
Bug 1265591 patch 1 - Remove Internal/External versions of ReconstructStyleData.  r=heycam

https://hg.mozilla.org/integration/mozilla-inbound/rev/f411f50ad23b194b570f2e30fe6b06b8881b183f
Bug 1265591 patch 2 - Rename nsIPresShell::ReconstructStyleData to RestyleForCSSRuleChanges.  r=heycam

https://hg.mozilla.org/integration/mozilla-inbound/rev/aea48706d499202a9d2b9b6bfd2292cc08fe1535
Bug 1265591 patch 3 - Make the comment describing RestyleForCSSRuleChanges match reality.  r=heycam
You need to log in before you can comment on or make changes to this bug.