Closed Bug 1265594 Opened 8 years ago Closed 8 years ago

Expose FromPropertyDescriptor() as a public JS API

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: ehsan.akhgari, Unassigned)

Details

Attachments

(1 file)

      No description provided.
Attachment #8742594 - Flags: review?(jorendorff)
SpiderNode issue to pick this up: https://github.com/mozilla/spidernode/issues/12
Comment on attachment 8742594 [details] [diff] [review]
Expose FromPropertyDescriptor() as a public JS API

Review of attachment 8742594 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the test.

Ideally this should be called JS::FromPropertyDescriptor. It's OK to get rid of the js:: version and just have everybody call the public function. But r=me with or without that change.
Attachment #8742594 - Flags: review?(jorendorff) → review+
Flags: needinfo?(ehsan)
https://hg.mozilla.org/mozilla-central/rev/980befcd0f73
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.