Closed
Bug 1265594
Opened 8 years ago
Closed 8 years ago
Expose FromPropertyDescriptor() as a public JS API
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
Details
Attachments
(1 file)
3.80 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•8 years ago
|
||
Attachment #8742594 -
Flags: review?(jorendorff)
Reporter | ||
Comment 2•8 years ago
|
||
SpiderNode issue to pick this up: https://github.com/mozilla/spidernode/issues/12
Comment 3•8 years ago
|
||
Comment on attachment 8742594 [details] [diff] [review] Expose FromPropertyDescriptor() as a public JS API Review of attachment 8742594 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the test. Ideally this should be called JS::FromPropertyDescriptor. It's OK to get rid of the js:: version and just have everybody call the public function. But r=me with or without that change.
Attachment #8742594 -
Flags: review?(jorendorff) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/8dbe34ec0786 for SM bustage https://treeherder.mozilla.org/logviewer.html#?job_id=26151108&repo=mozilla-inbound
Flags: needinfo?(ehsan)
Multiple crashes similar to https://treeherder.mozilla.org/logviewer.html#?job_id=26154998&repo=mozilla-inbound across multiple mochitest chunks, too.
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(ehsan)
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/980befcd0f73
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•