1265599 - developer-toolbar-toolbox-button checked attribute is gone

Status: VERIFIED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P1)

Description

[magicp]

Attachment: developer-toolbar-toolbox-button-checked-attribute.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160407164938

Steps to reproduce:

1. Start Nightly 48.0a1
2. Open Developer Toolbar (Shift + F2)
3. Click (Check) Toggle Developer Tools button (developer-toolbar-toolbox-button)
* If error counter displays, you should clear the web console output.


Actual results:

developer-toolbar-toolbox-button does not change to the checked status color, because the checked attribute is gone.


Expected results:

The checked attribute is available.

Comment 1

[magicp]

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3eb3406f08b594fe2b54926c6649eb8c5347104d&tochange=21be9fc9356d9ee4f396a5263b0aa1b47266eb8a

Comment 2

[Alexandre Poirot [:ochameau]]

Most likely regressed by bug 1248603.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2bf192afc362

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8746460 [details] [diff] [review]
patch v1

Review of attachment 8746460 [details] [diff] [review]:
-----------------------------------------------------------------

Joe, The developer-toolbar-toolbox-button used to overve the xul:observer related to DevToolbar comand.
Which I removed to only keep <xul:key> and <xul:menuitem> (no more <xul:observer> nor <xul:command>).
See http://mxr.mozilla.org/mozilla-central/source/devtools/client/shared/developer-toolbar.js#320

So there is no more magic xul ways to keep things in sync. Here I listen for toolbox events to update the "checked" state of this button.

Comment 6

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/a71289b135676f47c6efa094be92794f24fbc2f3
Bug 1265599 - Fix gcli toolbox button status when toolbox goes on and off. r=jwalker

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a71289b13567

Comment 8

[Mohammad Maruf Rahman]

I am trying to verify the bug with Nightly  48.0a1 but I am stuck at point 3.

Can anyone tell me how to find out the 'developer-toolbar-toolbox-button'.

Comment 9

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 48.0a1 (2016-04-18) on Windows 7, 64 Bit!

This bug's fix is verified on Latest Developer Edition, Latest Nightly

 Build ID     20160708004052
 User Agent   Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

 Build ID     20160714030208
 User Agent   Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0

Comment 10

[Bogdan Maris, Desktop QA]

Thanks for testing Maruf!
I also verified this using latest DevEdition 49.0a2 on Mac OS X 10.10.5.