developer-toolbar-toolbox-button checked attribute is gone

VERIFIED FIXED in Firefox 49

Status

defect
P1
normal
VERIFIED FIXED
3 years ago
7 months ago

People

(Reporter: magicp.jp, Assigned: ochameau)

Tracking

Trunk
Firefox 49

Firefox Tracking Flags

(firefox47 unaffected, firefox48 affected, firefox49 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160407164938

Steps to reproduce:

1. Start Nightly 48.0a1
2. Open Developer Toolbar (Shift + F2)
3. Click (Check) Toggle Developer Tools button (developer-toolbar-toolbox-button)
* If error counter displays, you should clear the web console output.


Actual results:

developer-toolbar-toolbox-button does not change to the checked status color, because the checked attribute is gone.


Expected results:

The checked attribute is available.
(Reporter)

Updated

3 years ago
Has STR: --- → yes
Component: Untriaged → Developer Tools: Graphic Commandline and Toolbar
OS: Unspecified → All
Hardware: Unspecified → All
(Reporter)

Updated

3 years ago
Flags: needinfo?(apoirot) → needinfo?(poirot.alex)
(Reporter)

Updated

3 years ago
(Assignee)

Comment 2

3 years ago
Most likely regressed by bug 1248603.
Blocks: 1248603
(Assignee)

Comment 3

3 years ago
Posted patch patch v1Splinter Review
(Assignee)

Updated

3 years ago
Flags: needinfo?(poirot.alex)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8746460 [details] [diff] [review]
patch v1

Review of attachment 8746460 [details] [diff] [review]:
-----------------------------------------------------------------

Joe, The developer-toolbar-toolbox-button used to overve the xul:observer related to DevToolbar comand.
Which I removed to only keep <xul:key> and <xul:menuitem> (no more <xul:observer> nor <xul:command>).
See http://mxr.mozilla.org/mozilla-central/source/devtools/client/shared/developer-toolbar.js#320

So there is no more magic xul ways to keep things in sync. Here I listen for toolbox events to update the "checked" state of this button.
Attachment #8746460 - Flags: review?(jwalker)
Attachment #8746460 - Flags: review?(jwalker) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/a71289b135676f47c6efa094be92794f24fbc2f3
Bug 1265599 - Fix gcli toolbox button status when toolbox goes on and off. r=jwalker

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a71289b13567
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee: nobody → poirot.alex
I am trying to verify the bug with Nightly  48.0a1 but I am stuck at point 3.

Can anyone tell me how to find out the 'developer-toolbar-toolbox-button'.
I have reproduced this bug with Nightly 48.0a1 (2016-04-18) on Windows 7, 64 Bit!

This bug's fix is verified on Latest Developer Edition, Latest Nightly

 Build ID     20160708004052
 User Agent   Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

 Build ID     20160714030208
 User Agent   Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Thanks for testing Maruf!
I also verified this using latest DevEdition 49.0a2 on Mac OS X 10.10.5.
Status: RESOLVED → VERIFIED

Updated

10 months ago
Product: Firefox → DevTools

Updated

7 months ago
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.