Closed Bug 1265679 Opened 7 years ago Closed 7 years ago

Always call the object moved hook when tenuring an object

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

call-object-move-hook-when-tenuring
2.38 KB, patch
terrence
: review+
Details | Diff | Splinter Review 
At the moment we only call the object moved hook if the class has the JSCLASS_SKIP_NURSERY_FINALIZE flag set.  It seems to me that if the hook is present then we should always call it when tenuring an object, for those objects that don't have special case tenuring behaviour.
Attachment #8742736 - Flags: review?(terrence)
Attachment #8742736 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/b0eb077d0e89
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.