1265718 - Decouple fronts from actors in animation inspector.

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, enhancement, P1)

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Decouple AnimationPlayerFront from AnimationPlayerActor.

Comment 2

[Eddy Bruel [:ejpbruel]]

Attachment: Decouple AnimationsFront from AnimationsActor.

Comment 3

[Eddy Bruel [:ejpbruel]]

Try push for the patch to decouple AnimationPlayerFront from AnimationPlayerActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3483dbe4173

Comment 4

[Eddy Bruel [:ejpbruel]]

Previous try push for patch to decouple AnimationPlayerFront from AnimationPlayer had test failures due to capitalisation errors. New try push with issues addressed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fefef0a85b11

Comment 5

[Eddy Bruel [:ejpbruel]]

Try push for patch to decouple AnimationPlayerFront from AnimationPlayer looks good, but I had to rebase over some ESLint fixes. Here's another try push to make sure I didn't break anything during rebase:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=941b520f902f

Comment 6

[Eddy Bruel [:ejpbruel]]

Try push for the patch to decouple AnimationsFront from AnimationsActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb05e74ab75b

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e8f4f77bd99e

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/25a5ae2711f3

Comment 9

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=9491138&repo=fx-team

Comment 10

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/74fe05a5f015

Comment 11

[Eddy Bruel [:ejpbruel]]

Try push for the patch to decouple AnimationsFront from AnimationsActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d54ab0f97b12

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3c599aa289d8

Comment 13

[Carsten Book [:Tomcat]]

backed out again for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=9526403&repo=fx-team

Comment 14

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/2a2ce43bcafb

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e8f4f77bd99e

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9afab6308cd9

Comment 17

[Eddy Bruel [:ejpbruel]]

I fixed the test errors that were the cause for the last backout. Let's hope the patch sticks this time.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9afab6308cd9