Closed Bug 1265743 Opened 7 years ago Closed 7 years ago

mach talos-test uses --setPref instead of --setpref (inconsistent with all other mach commands)

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox48 affected, firefox50 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox48 --- affected
firefox50 --- fixed

People

(Reporter: kats, Assigned: malayaleecoder)

Details

(Whiteboard: [talos_wishlist])

Attachments

(1 file)

Bug1265743_v1.diff
1.60 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
Most mach commands that allow flipping prefs (e.g. mochitests) take --setpref PREF=VALUE arguments. The talos-test command though takes --setPref (with an uppercase P) and doesn't accept --setpref. This inconsistency seems unnecessary and we should fix it. I don't know if people have scripts and such that are using --setPref that might break - maybe we need to accept both?
Whiteboard: [talos_wishlist]
Assignee: nobody → sumanvid97
I think this should be it. With reference to comment #1 , should we accept both of the forms? Please have a look.
Attachment #8776069 - Flags: review?(jmaher)
Sorry, comment #0
Attachment #8776069 - Flags: review?(jmaher) → review+
Assignee: sumanvid97 → malayaleecoder
Status: NEW → ASSIGNED
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d69343be1c24
mach talos-test uses --setPref instead of --setpref (inconsistent with all other mach commands). r=jmaher
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d69343be1c24
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.