1265766 - Use TimeUnit class to initialize TelemetryUploadService.MILLIS_IN_DAY

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android/Suggested_workflow#Creating_commits_and_submitting_patches

You can find more miscellaneous information at: https://wiki.mozilla.org/Mobile/Fennec/Android

To fix this bug, in the TelemetryUploadService class, change modify the assignment of the `MILLIS_IN_DAY` variable to use the TimeUnit class instead.

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 1

[Juan Fernandez]

Hi Michael, I want to work on this bug.(it will be my first bug).

Comment 2

[bzrd_Sdn]

Attachment: TimeUnit.diff

patch for Bug 1265766
I made a patch can you tell me if this is correct?
 thank you

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Juan Fernandez from comment #1)
> Hi Michael, I want to work on this bug.(it will be my first bug).

Hi Juan – I'm actually going to close this bug because my upcoming changes in bug 1243585 will overwrite this. Would you like to look at bug 1261210 instead? Just comment there so we know you're working on it and we'll assign you when you post a patch.

bzrd_Sdn, if someone else has asked to work on a bug recently, please give them the opportunity to work on it. We can continue working on bug 1266199.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8743856 [details] [diff] [review]
TimeUnit.diff

(includes other changes & does not appear to compile)