Don't look for a prototype for our interface object if we don't plan to have an interface object

RESOLVED FIXED in Firefox 48

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

We already do this in cases when we have no interface prototype object (skip looking for a prototype for that nonexistent thing).  We should do the same for interface objects.  Without that, a [NoInterfaceObject] thing inheriting from another [NoInterfaceObject] thing is broken, because it will try to get the (nonexistent, hence with no way to get it) interface object of the parent.
Created attachment 8742890 [details] [diff] [review]
Don't try to get a prototype for the interface object for an interface that's [NoInterfaceObject], since it's just unnecessary work that can't even be done at all in some cases (e.g. when the parent interface is also [NoInterfaceObject])
Attachment #8742890 - Flags: review?(peterv)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Whiteboard: btpp-active
Attachment #8742890 - Flags: review?(peterv) → review+

Comment 2

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b03e85de220

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4b03e85de220
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.