|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
Replace uses of Service.console as part of the de-chrome-ification project.
Summary: replace Service.console → replace Services.console
Of course I typod the name and it is "Services.console".
Severity: normal → enhancement
Created attachment 8743405 [details] [diff] [review] use console.log, not Services.console.logStringMessage MozReview-Commit-ID: Ax4EwhRVE0R This fixes uses of Services.console, with a few minor exceptions: * server/, of course * shared/webconsole, where some seem to be related to the actor; the code is a bit intermingled here * tests, but again as they are tests specifically for webconsole, maybe they can't be changed (I didn't look too deeply)
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Created attachment 8744478 [details] MozReview Request: Bug 1265772 - don't use Services.console or Console.jsm in devtools; r?bgrins Review commit: https://reviewboard.mozilla.org/r/48567/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48567/
Attachment #8744478 - Flags: review?(bgrinstead)
Attachment #8743405 - Attachment is obsolete: true
I forgot to note - this removes Console.jsm uses from most, but not all, spots. A few remain in other jsms, in loaders, and in tests.
Attachment #8744478 - Flags: review?(bgrinstead) → review+
Comment on attachment 8744478 [details] MozReview Request: Bug 1265772 - don't use Services.console or Console.jsm in devtools; r?bgrins https://reviewboard.mozilla.org/r/48567/#review45593 Works for me, thanks
Something went wrong with that try run, but here's a better one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ea2b37ea3c072008e24da0b4583126206f9814b
Iteration: --- → 49.1 - May 9
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.