Closed Bug 1265928 Opened 4 years ago Closed 4 years ago

Hide Adobe GMP on Windows XP in Firefox 46 and 47.

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox46 blocking fixed
firefox47 + fixed
firefox48 --- wontfix
firefox49 --- wontfix

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file, 1 obsolete file)

We need to hide the Adobe GMP on Windows XP. i.e. we need to revert bug 1234099.

This is because we detected that we're getting lots of crashes with unencrpyted decoding using the Adobe GMP, and we only use it on Windows XP for unencrypted decoding, so we should not show it in the UI.
Attached patch Hide Adobe GMP on Windows XP (obsolete) — Splinter Review
We need to revert bug 1234099 so that we don't show the plugin in
the add-on manager on Windows XP, since now that unencrypted decoding
via Adobe GMP is disabled, we won't be using the Adobe GMP.
We need to revert bug 1234099 so that we don't show the plugin in
the add-on manager on Windows XP, since now that unencrypted decoding
via Adobe GMP is disabled, we won't be using the Adobe GMP.
Attachment #8743054 - Attachment is obsolete: true
Comment on attachment 8743056 [details] [diff] [review]
Hide Adobe GMP on Windows XP

Review of attachment 8743056 [details] [diff] [review]:
-----------------------------------------------------------------

Carried r+ over from bug 1265815.
Attachment #8743056 - Flags: review+
Comment on attachment 8743056 [details] [diff] [review]
Hide Adobe GMP on Windows XP

Approval Request Comment
[Feature/regressing bug #]: Download of Adobe Gecko Media Plugin/Content Decryption Module on Windows XP
[User impact if declined]: Adobe CDM will be downloaded and appear in the add-on manager, but won't be used by Firefox or do anything. Will confuse users.
[Describe test coverage new/current, TreeHerder]: We have tests for this
[Risks and why]: Fairly low; this is a revert to previous behaviour
[String/UUID change made/needed]: None
Attachment #8743056 - Flags: approval-mozilla-beta?
Attachment #8743056 - Flags: approval-mozilla-aurora?
Comment on attachment 8743056 [details] [diff] [review]
Hide Adobe GMP on Windows XP

[Triage Comment]

Hide the plugin since it is causing crashes. Please uplift to aurora, m-b an m-r.
Attachment #8743056 - Flags: approval-mozilla-release+
Attachment #8743056 - Flags: approval-mozilla-beta?
Attachment #8743056 - Flags: approval-mozilla-beta+
Attachment #8743056 - Flags: approval-mozilla-aurora?
Attachment #8743056 - Flags: approval-mozilla-aurora+
Fixed in comment 6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.