1265934 - Android: Username is overwritten with a blank one when updating the password for a Twitter account

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect, P1)

Description

[Matthew N. [:MattN]]

We fixed the below for desktop in bug 1243729 but the fork for Android at https://mxr.mozilla.org/mozilla-central/source/mobile/android/components/LoginManagerPrompter.js?rev=b6e38de09b1a#276 wasn't fixed.

+++ This bug was initially created as a clone of Bug #1243729 +++

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160127030236

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160123151951

Prerequisites:
Have at least 2 logins saved for Twitter in browser.

Steps to Reproduce:
1. Login to Twitter with one of the saved accounts.
2. Go to Twitter->Settings->Password screen.
3. Enter the current password and the new one.
4. Click on "Save changes" button.
5. Select from `Confirm Password Change` window the username for which the password has been changed.
6. Click on "OK" button.
7. Open a new tab and go to about:preferences#security, click on "Saved Logins..." button.
8. Observe the username for which the password has been changed.

Expected results:
The username is displayed and only the password is updated.

Actual results:
The username is blank.

This issue is reproducible also on Windows 10, Mac OS X 10.11.
==

Tim, can you make the same change as attachment 8740261 [details] [diff] [review] but for mobile?

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Margaret, making sure you see this. We can still land a fix for this in fennec beta 13.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Kevin can you test this before we uplift once Tim lands a fix?  We are a little bit rushed (hoping to land this on m-b tonight or early tomorrow morning)

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Is this bug still repro on Fennec? I am seeing `this._updateLogin(selectedLogin, aNewLogin.password);` here; `_updateLogin()` does not take `aNewLogin` as a whole as the argument.

https://mxr.mozilla.org/mozilla-central/source/mobile/android/components/LoginManagerPrompter.js?rev=b6e38de09b1a#306

Comment 4

[Matthew N. [:MattN]]

Good point, I guess bug 1016051 didn't get fixed for Android so this bug isn't present. Sorry about that. We can file a separate bug to port bug 1016051 to Android.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks for checking. We don't need to track this, then.