1265974 - Don't fire push events in MediaQueue::PushFront()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

The only user of MediaQueue::PushFront() is VideoSink::UpdateRenderedVideoFrames() to push old data back to the queue. In fact we should fire push events only when new data is pushed to the queue.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1265974 - Don't fire push events in MediaQueue::PushFront(). r=jya.

Review commit: https://reviewboard.mozilla.org/r/47985/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47985/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8743647 [details]
MozReview Request: Bug 1265974 - Don't fire push events in MediaQueue::PushFront(). r=jya.

https://reviewboard.mozilla.org/r/47985/#review44777

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6440d8e37e67

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6440d8e37e67