Closed Bug 1265974 Opened 4 years ago Closed 4 years ago

Don't fire push events in MediaQueue::PushFront()

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

The only user of MediaQueue::PushFront() is VideoSink::UpdateRenderedVideoFrames() to push old data back to the queue. In fact we should fire push events only when new data is pushed to the queue.
See Also: → 1265969
Assignee: nobody → jwwang
Comment on attachment 8743647 [details]
MozReview Request: Bug 1265974 - Don't fire push events in MediaQueue::PushFront(). r=jya.

https://reviewboard.mozilla.org/r/47985/#review44777
Attachment #8743647 - Flags: review?(jyavenard) → review+
Thanks!
https://hg.mozilla.org/mozilla-central/rev/6440d8e37e67
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.