Rename "Exec with this profile" to "Launch profile in new browser" in about:profiles

RESOLVED FIXED in Firefox 48

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

47 Branch
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Created attachment 8743198 [details] [diff] [review]
p2.patch

Comment 1

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/beca0a890471
(Assignee)

Comment 2

2 years ago
r=me. It's just a renaming.
(In reply to Andrea Marchesini (:baku) from comment #2)
> r=me. It's just a renaming.

It's not. You're completely changing an existing string, and you need a new string ID.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
Flags: needinfo?(amarchesini)
(Assignee)

Comment 4

2 years ago
Created attachment 8743225 [details] [diff] [review]
p3.patch
Flags: needinfo?(amarchesini)
Attachment #8743225 - Flags: review?(francesco.lodolo)
Comment on attachment 8743225 [details] [diff] [review]
p3.patch

Review of attachment 8743225 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that works.
Attachment #8743225 - Flags: review?(francesco.lodolo) → review+

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa69a1d362bb
Whiteboard: btpp-active

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/beca0a890471
https://hg.mozilla.org/mozilla-central/rev/aa69a1d362bb
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.