Closed Bug 1266016 Opened 8 years ago Closed 8 years ago

Rename "Exec with this profile" to "Launch profile in new browser" in about:profiles

Categories

(Core :: DOM: Core & HTML, defect)

47 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Whiteboard: btpp-active)

Attachments

(2 files)

Attached patch p2.patchSplinter Review
      No description provided.
r=me. It's just a renaming.
(In reply to Andrea Marchesini (:baku) from comment #2)
> r=me. It's just a renaming.

It's not. You're completely changing an existing string, and you need a new string ID.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
Flags: needinfo?(amarchesini)
Attached patch p3.patchSplinter Review
Flags: needinfo?(amarchesini)
Attachment #8743225 - Flags: review?(francesco.lodolo)
Comment on attachment 8743225 [details] [diff] [review]
p3.patch

Review of attachment 8743225 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that works.
Attachment #8743225 - Flags: review?(francesco.lodolo) → review+
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/beca0a890471
https://hg.mozilla.org/mozilla-central/rev/aa69a1d362bb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: