Closed
Bug 1266033
Opened 8 years ago
Closed 8 years ago
|nsDBusHandlerApp| leaks |DBusConnection|
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
(Whiteboard: btpp-active)
Attachments
(4 files)
3.17 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
1.20 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
1.46 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
944 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|nsDBusHandlerApp| acquires [1] a reference to the DBus session bus, but never releases the connection. [1] https://dxr.mozilla.org/mozilla-central/source/uriloader/exthandler/nsDBusHandlerApp.cpp#90
Assignee | ||
Comment 1•8 years ago
|
||
Cleaning up before doing actual fixes.
Attachment #8743218 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8743219 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8743221 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 4•8 years ago
|
||
We have seen multi-threading bugs with Bluetooth, where DBus messages where handled on any thread that watched the shared DBus connection. Using a private connection avoids these problems.
Attachment #8743222 -
Flags: review?(bzbarsky)
Comment 5•8 years ago
|
||
Comment on attachment 8743218 [details] [diff] [review] [00] Bug 1266033: Fix white-space errors in |nsDBusHandlerApp| r=me
Attachment #8743218 -
Flags: review?(bzbarsky) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8743219 [details] [diff] [review] [01] Bug 1266033: |nsDBusHandlerApp|: Hold reference to |DBusConnection| in |RefPtr| r=me
Attachment #8743219 -
Flags: review?(bzbarsky) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8743221 [details] [diff] [review] [02] Bug 1266033: |nsDBusHandlerApp|: Hold reference to |DBusMessage| in |RefPtr| r=me
Attachment #8743221 -
Flags: review?(bzbarsky) → review+
Comment 8•8 years ago
|
||
Comment on attachment 8743222 [details] [diff] [review] [03] Bug 1266033: |nsDBusHandlerApp|: Use private connection to DBus session bus r=me I guess, but I have no idea why this is the right thing to do... ;)
Attachment #8743222 -
Flags: review?(bzbarsky) → review+
Updated•8 years ago
|
Whiteboard: btpp-active
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #8) > Comment on attachment 8743222 [details] [diff] [review] > [03] Bug 1266033: |nsDBusHandlerApp|: Use private connection to DBus session > bus > > r=me I guess, Thanks :) > but I have no idea why this is the right thing to do... ;) There are other users of the session bus. These modules use the same DBus connection. If they run concurrently on a different thread or modify the connection concurrently, it could interfere with |nsDBusHandlerApp|. As mentioned, we had this with Bluetooth. With the patch applied, |nsDBusHandlerApp| uses it's own, private connection, which won't interfere with other modules.
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/43730c92b372 https://hg.mozilla.org/integration/mozilla-inbound/rev/e65d8d0f3f5d https://hg.mozilla.org/integration/mozilla-inbound/rev/2eff1cd6a1fe https://hg.mozilla.org/integration/mozilla-inbound/rev/8b76cbb69bef
Assignee | ||
Comment 11•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8b76cbb69bef
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/43730c92b372 https://hg.mozilla.org/mozilla-central/rev/e65d8d0f3f5d https://hg.mozilla.org/mozilla-central/rev/2eff1cd6a1fe https://hg.mozilla.org/mozilla-central/rev/8b76cbb69bef
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•