crash in mozilla::AudioBufferAddWithScale_SSE

RESOLVED FIXED in Firefox 48

Status

()

defect
--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jujjyl, Assigned: dminor)

Tracking

({crash})

48 Branch
mozilla48
x86_64
Windows 10
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(crash signature)

Attachments

(1 attachment)

Reporter

Description

3 years ago
This bug was filed from the Socorro interface and is 
report bp-3cde381c-ace2-4953-9cbe-8529c2160420.
=============================================================

On current Firefox Nightly, crashed deterministically several times in a row.

STR:

1. Open https://apps.facebook.com/topeleven/
2. After game loads, and teams are shown, on left-hand side, choose "Training"

After the training screen shows up, game crashes.

Crash reports:

https://crash-stats.mozilla.com/report/index/3cde381c-ace2-4953-9cbe-8529c2160420
https://crash-stats.mozilla.com/report/index/c63aeed7-2c97-4483-b8fd-879d22160420
https://crash-stats.mozilla.com/report/index/28216b73-6ff1-4b0b-a6ba-316122160420
Assignee

Updated

3 years ago
Assignee: nobody → dminor
Assignee

Updated

3 years ago
See Also: → 1266112
Assignee

Comment 1

3 years ago
This adds alignment checks to fallback to scalar operations if the
received buffers are not properly aligned. Bug 1266112 is the follow on
to either fix the alignment problem or add a vector path for the aligned
portion of the buffers.

Review commit: https://reviewboard.mozilla.org/r/47719/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47719/
Attachment #8743323 - Flags: review?(padenot)
Comment on attachment 8743323 [details]
MozReview Request: Bug 1266047 - Fix crash in mozilla::AudioBufferAddWithScale_SSE r=padenot

https://reviewboard.mozilla.org/r/47719/#review44509
Attachment #8743323 - Flags: review?(padenot) → review+
Assignee

Comment 3

3 years ago
Comment on attachment 8743323 [details]
MozReview Request: Bug 1266047 - Fix crash in mozilla::AudioBufferAddWithScale_SSE r=padenot

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47719/diff/1-2/
Attachment #8743323 - Attachment description: MozReview Request: Bug 1266047 - crash in mozilla::AudioBufferAddWithScale_SSE r?padenot → MozReview Request: Bug 1266047 - Fix crash in mozilla::AudioBufferAddWithScale_SSE r=padenot

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d6411584d7b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.