Closed Bug 1266077 Opened 7 years ago Closed 7 years ago

Fix <base> href getter to follow updated spec

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 1 obsolete file)

Fix <base> href getter to follow the spec; it should be using the fallback base URI to resolve against, not the document URI
6.52 KB, patch
bkelly
: review+
Details | Diff | Splinter Review 
See https://github.com/whatwg/html/issues/1060 for the spec bits.  We should be using the fallback base URI, not the document URI, for this reflection.
Attachment #8743288 - Attachment is obsolete: true
Attachment #8743288 - Flags: review?(bkelly)
Whiteboard: btpp-active
Comment on attachment 8743294 [details] [diff] [review]
Fix <base> href getter to follow the spec; it should be using the fallback base URI to resolve against, not the document URI

Review of attachment 8743294 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM based on the outcome of that spec issue.
Attachment #8743294 - Flags: review?(bkelly) → review+
https://hg.mozilla.org/mozilla-central/rev/1d1b0febedc2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.