Closed Bug 1266080 Opened 4 years ago Closed 4 years ago

Move new google-no code in list.txt

Categories

(Firefox for Android :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: mkaply, Unassigned)

Details

Attachments

(1 file)

iOS depends on the order of the engines in list.txt, so before the next iOS uplift, google-nocodes should be moved after google:hidden.

(Probably should have done that in the first place).

Not needed for release because Android does not appear to depend on the order in the file.
Does this need to be moco-confidential?
Group: mozilla-employee-confidential
Sorry for the weekend review request. Realized I wanted to try to get this in before the merge (since iOS gets search engines from aurora).
Attachment #8744592 - Flags: review?(mark.finkle)
Attachment #8744592 - Flags: review?(margaret.leibovic)
Comment on attachment 8744592 [details] [diff] [review]
Change order of file

Review of attachment 8744592 [details] [diff] [review]:
-----------------------------------------------------------------

Out of curiosity, how exactly does iOS depend on the order here? This current list doesn't reflect our default engine order, nor is it alphabetical, so I'm wondering how this makes a difference.
Attachment #8744592 - Flags: review?(margaret.leibovic) → review+
> Out of curiosity, how exactly does iOS depend on the order here? This current list doesn't reflect our default engine order, nor is it alphabetical, so I'm wondering how this makes a difference.

On iOS, the list at the bottom of the app is based directly on the order of list.txt:

https://github.com/mozilla/firefox-ios/blob/01a471f60424224bc8db8f29f01c00cebb99f1ef/Client/Frontend/Browser/SearchEngines.swift#L208

So if I add google-nocodes at the end, it will be on the far right on iOS.
https://hg.mozilla.org/mozilla-central/rev/3cfe3ba1ed21
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Attachment #8744592 - Flags: review?(mark.finkle)
You need to log in before you can comment on or make changes to this bug.