1266080 - Move new google-no code in list.txt

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Kaply [:mkaply]]

iOS depends on the order of the engines in list.txt, so before the next iOS uplift, google-nocodes should be moved after google:hidden.

(Probably should have done that in the first place).

Not needed for release because Android does not appear to depend on the order in the file.

Comment 1

[:Margaret Leibovic]

Does this need to be moco-confidential?

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Change order of file

Sorry for the weekend review request. Realized I wanted to try to get this in before the merge (since iOS gets search engines from aurora).

Comment 3

[:Margaret Leibovic]

Comment on attachment 8744592 [details] [diff] [review]
Change order of file

Review of attachment 8744592 [details] [diff] [review]:
-----------------------------------------------------------------

Out of curiosity, how exactly does iOS depend on the order here? This current list doesn't reflect our default engine order, nor is it alphabetical, so I'm wondering how this makes a difference.

Comment 4

[Mike Kaply [:mkaply]]

> Out of curiosity, how exactly does iOS depend on the order here? This current list doesn't reflect our default engine order, nor is it alphabetical, so I'm wondering how this makes a difference.

On iOS, the list at the bottom of the app is based directly on the order of list.txt:

https://github.com/mozilla/firefox-ios/blob/01a471f60424224bc8db8f29f01c00cebb99f1ef/Client/Frontend/Browser/SearchEngines.swift#L208

So if I add google-nocodes at the end, it will be on the far right on iOS.

Comment 5

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/fx-team/rev/3cfe3ba1ed21c24a62d442f5645afb0fb6ed5e59
Bug 1266080 - Move Google engines together in list; r=margaret

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cfe3ba1ed21