Closed
Bug 1266104
Opened 8 years ago
Closed 8 years ago
crash in java.lang.IllegalStateException: SavedReaderView items must be explicitly loaded using loadItems() before access. at org.mozilla.gecko.reader.SavedReaderViewHelper.assertItemsLoaded(SavedReaderViewHelper.java)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed, fennec48+)
RESOLVED
FIXED
Firefox 48
People
(Reporter: sebastian, Assigned: ahunt)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
My Nightly just crashed on first start after the update. This bug was filed from the Socorro interface and is report bp-d824038e-b5eb-4c49-8dc8-b08e52160420. =============================================================
Reporter | ||
Comment 1•8 years ago
|
||
> java.lang.IllegalStateException: SavedReaderView items must be explicitly loaded using loadItems() before access.
> at org.mozilla.gecko.reader.SavedReaderViewHelper.assertItemsLoaded(SavedReaderViewHelper.java:110)
> at org.mozilla.gecko.reader.SavedReaderViewHelper.isURLCached(SavedReaderViewHelper.java:124)
> at org.mozilla.gecko.home.TwoLinePageRow.updateFromCursor(TwoLinePageRow.java:306)
> at org.mozilla.gecko.home.RecentTabsPanel$RecentTabsAdapter.bindView(RecentTabsPanel.java:408)
> at org.mozilla.gecko.home.MultiTypeCursorAdapter.getView(MultiTypeCursorAdapter.java:62)
> at android.widget.AbsListView.obtainView(AbsListView.java:2346)
> at android.widget.ListView.makeAndAddView(ListView.java:1876)
> at android.widget.ListView.fillDown(ListView.java:702)
> at android.widget.ListView.fillFromTop(ListView.java:763)
> at android.widget.ListView.layoutChildren(ListView.java:1671)
> at android.widget.AbsListView.onLayout(AbsListView.java:2148)
> at android.view.View.layout(View.java:16636)
> [..]
Updated•8 years ago
|
Assignee: nobody → ahunt
Comment 3•8 years ago
|
||
It appears this may have been caused by a bad interaction with the local/remote visits DB migration. I kept encountering this crash on startup, and at the same time in the log I could see that my DB migration was restarting every time I launched the app. I think this is probably a valid crash, but one that was tickled by the DB being preoccupied with a long-running migration.
Assignee | ||
Comment 4•8 years ago
|
||
I wonder if there is a better solution to guarantee we have the necessary data loaded, however this seems to be the only special case (i.e. the only place we use TwoLinePageRow without the DB having been loaded first). Review commit: https://reviewboard.mozilla.org/r/47855/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47855/
Comment 5•8 years ago
|
||
Comment on attachment 8743503 [details] MozReview Request: Bug 1266104 - Ensure SavedReaderViewHelper is loaded for recent tabs panel https://reviewboard.mozilla.org/r/47855/#review44569 Seems fine to me, and this panel is going away soon anyway.
Attachment #8743503 -
Flags: review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a1823d3e691960016d156ed062eb416d2d135707 Bug 1266104 - Ensure SavedReaderViewHelper is loaded for recent tabs panel r=margaret
Updated•8 years ago
|
tracking-fennec: ? → 48+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a1823d3e6919
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•