Closed Bug 1266104 Opened 4 years ago Closed 4 years ago
crash in java
.lang .Illegal State Exception: Saved Reader View items must be explicitly loaded using load Items() before access . at org .mozilla .gecko .reader .Saved Reader View Helper .assert Items Loaded(Saved Reader View Helper .java)
58 bytes, text/x-review-board-request
My Nightly just crashed on first start after the update. This bug was filed from the Socorro interface and is report bp-d824038e-b5eb-4c49-8dc8-b08e52160420. =============================================================
> java.lang.IllegalStateException: SavedReaderView items must be explicitly loaded using loadItems() before access. > at org.mozilla.gecko.reader.SavedReaderViewHelper.assertItemsLoaded(SavedReaderViewHelper.java:110) > at org.mozilla.gecko.reader.SavedReaderViewHelper.isURLCached(SavedReaderViewHelper.java:124) > at org.mozilla.gecko.home.TwoLinePageRow.updateFromCursor(TwoLinePageRow.java:306) > at org.mozilla.gecko.home.RecentTabsPanel$RecentTabsAdapter.bindView(RecentTabsPanel.java:408) > at org.mozilla.gecko.home.MultiTypeCursorAdapter.getView(MultiTypeCursorAdapter.java:62) > at android.widget.AbsListView.obtainView(AbsListView.java:2346) > at android.widget.ListView.makeAndAddView(ListView.java:1876) > at android.widget.ListView.fillDown(ListView.java:702) > at android.widget.ListView.fillFromTop(ListView.java:763) > at android.widget.ListView.layoutChildren(ListView.java:1671) > at android.widget.AbsListView.onLayout(AbsListView.java:2148) > at android.view.View.layout(View.java:16636) > [..]
My nightly is permanently crashing with this.
tracking-fennec: --- → ?
It appears this may have been caused by a bad interaction with the local/remote visits DB migration. I kept encountering this crash on startup, and at the same time in the log I could see that my DB migration was restarting every time I launched the app. I think this is probably a valid crash, but one that was tickled by the DB being preoccupied with a long-running migration.
I wonder if there is a better solution to guarantee we have the necessary data loaded, however this seems to be the only special case (i.e. the only place we use TwoLinePageRow without the DB having been loaded first). Review commit: https://reviewboard.mozilla.org/r/47855/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47855/
Comment on attachment 8743503 [details] MozReview Request: Bug 1266104 - Ensure SavedReaderViewHelper is loaded for recent tabs panel https://reviewboard.mozilla.org/r/47855/#review44569 Seems fine to me, and this panel is going away soon anyway.
Attachment #8743503 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/a1823d3e691960016d156ed062eb416d2d135707 Bug 1266104 - Ensure SavedReaderViewHelper is loaded for recent tabs panel r=margaret
You need to log in before you can comment on or make changes to this bug.