Created attachment 8743370 [details] Screenshot 2016-04-20 10.23.43.png See attached screenshot. If this is because the text label for 'New Private Tab' is longer than expected then please keep in mind that for some locales this text will be even longer. Do we need to consider letting this label use multiple lines? Tracking 4.0 because I think we want to get this right for the shipping version?
Created attachment 8743886 [details] [review] Pull request
Comment on attachment 8743886 [details] [review] Pull request +++ Nice work, James! Thirds works in all devices/orientations! The bottom padding is good, too.
Attachment #8743886 - Flags: ui-review?(randersen) → ui-review+
Comment on attachment 8743886 [details] [review] Pull request Looks good. I'm just afraid that we delay adding the copied link UI too much because there is a lot of flashing and animation going on when that part gets added. Specially on iPad landscape it looks really odd where the buttons seem to slide in from the right side and then after a short delay the copied link UI moves in over that. Followup bug if other people also see this?
Attachment #8743886 - Flags: review?(sarentz) → review+
Followup filed. Squashed and merged.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
status-fxios-v4.0: --- → fixed
Target Milestone: --- → 4.0
Verifying this as fixed on build 4.0.0b5
Status: RESOLVED → VERIFIED
status-fxios-v4.0: fixed → verified
You need to log in before you can comment on or make changes to this bug.