1266136 - Today Widget margins are incorrect

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Screenshot 2016-04-20 10.23.43.png

See attached screenshot.

If this is because the text label for 'New Private Tab' is longer than expected then please keep in mind that for some locales this text will be even longer. Do we need to consider letting this label use multiple lines?

Tracking 4.0 because I think we want to get this right for the shipping version?

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: Pull request

Comment 2

[Robin Andersen [:tecgirl]]

Comment on attachment 8743886 [details] [review]
Pull request

+++
Nice work, James! Thirds works in all devices/orientations! The bottom padding is good, too.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8743886 [details] [review]
Pull request

Looks good.

I'm just afraid that we delay adding the copied link UI too much because there is a lot of flashing and animation going on when that part gets added. Specially on iPad landscape it looks really odd where the buttons seem to slide in from the right side and then after a short delay the copied link UI moves in over that. Followup bug if other people also see this?

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Followup filed.

Squashed and merged.

Comment 6

[Catalin Suciu [:csuciu]]

Verifying this as fixed on build 4.0.0b5