1266142 - Radio button labels aren't vertically aligned with the circle on the devtools settings/options pane

Status: VERIFIED FIXED

(DevTools :: General, defect, P3)

Description

[Matthew N. [:MattN]]

Attachment: Screen Shot 2016-04-20 at 10.15.52 AM.png

Checkbox labels seem more vertically aligned than the radio buttons.

Comment 1

[Matthew N. [:MattN]]

This happens on all platforms btw. You can see screenshots of 4_options at https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=ae7413abfa4d3954a6a4ce7c1613a7100f367f9a&newProject=mozilla-central&newRev=f05a1242fb29023bd7ebc492897ed3d6907733c7#

Comment 2

[[:Towkir] Ahmed]

Attachment: vertically_centered_?.png

Hi, 
I was about to file another bug about it, luckily found it.
I have already fixed this,
See my attached screenshot left part is buggy, and right side is the fixed one, 
I will submit the patch soon.
Thanks

Comment 3

[[:Towkir] Ahmed]

Attachment: fixed_label_vertical_alignment.patch

Here is the patch

Comment 4

[[:Towkir] Ahmed]

Taking this on me

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: align.png

Here is what I get on Linux/Ubuntu.
Does your patch depend on some other changes?
Are you based against recent fx-team or mozilla-central checkout?

Comment 6

[[:Towkir] Ahmed]

(In reply to Alexandre Poirot [:ochameau] from comment #5)

> Does your patch depend on some other changes?
I don't think so, I cleared all other changes, 
> Are you based against recent fx-team or mozilla-central checkout?
I was on mozilla-central

I think the css value should be 
	align-items: center;

You can try at your end with this value, then I can edit and submit a new patch.
thanks

Comment 7

[Alexandre Poirot [:ochameau]]

Same result with align-items: center :/

Comment 8

[Alexandre Poirot [:ochameau]]

Wait a sec. I do have some patchs on my queue. Let me try without them.

Comment 9

[[:Towkir] Ahmed]

I have just tried it on another (fresh) PC before comment 6. this should have been the solution.
Dunno what's happening at yours

Comment 10

[Alexandre Poirot [:ochameau]]

Comment on attachment 8766506 [details] [diff] [review]
fixed_label_vertical_alignment.patch

Review of attachment 8766506 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I had one local patch messing up with this.
It looks good, thanks for this polish!

Comment 11

[[:Towkir] Ahmed]

As you have approved, I think it is time :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/69e91ad4fb9f
Fixed radio button labels vertical alignment in devtools settings/options pane. r=ochameau

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69e91ad4fb9f

Comment 14

[[:Towkir] Ahmed]

Ummm.....
Looks like this issue is existing in the browser toolbox too. Where do I find the code for that please ?
Should it be in this bug or a new one should be filed ?

Comment 15

[[:Towkir] Ahmed]

Sorry for the previous comment 14. I had some issues with browser updates. 
----------------------------------------
This is fixed on latest nightly
----------------------------------------
Version 	50.0a1
Build ID 	20160715063552
Update Channel 	nightly
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
OS 	Linux 4.2.0-41-generic

Comment 16

[arni2033]

Attachment: screenshot 4 - different vertical alignment of text labels.png

This is regression from bug 1246514. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=5b3f81a3277026268277c0ba4fe4815de7751228&tochange=5c5cf183a60890e651380e00533ce10d60375ffb

I can't completely verify this on:   Win7_64, Nightly 50, 32bit, ID 20160702030219   (2016-07-02)
because text labels aren't aligned the same way on checkboxes and radio buttons.
See attached "screenshot 4" for explanation.

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Too late for 48, please submit an uplift to 49.

Comment 18

[Farhadur Reja Fahim]

I have reproduced this bug with Nightly 48.0a1 (2016-04-20) on Ubuntu 14.04, 64 bit!
The bug's fix is now verified on latest Nightly 51.0a1

Nightly 51.0a1:
Build ID 	20160804030441
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

Comment 19

[Md. Rahimul Islam]

I have successfully reproduce this bug on firefox nightly 48.0a1 (2016-04-20)
with windows 7 (32 bit)
Mozilla/5.0 (Windows NT 6.1; rv:48.0) Gecko/20100101 Firefox/48.0

I found this fix on latest nightly 51.0a1 (2016-08-02)

Mozilla/5.0 (Windows NT 6.1; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID : 20160802030437

[bugday-20160803]

Comment 20

[Gerry Chang [:gchang]]

Hi :Towkir,
Since this bug is a regression and also affects 49, do you consider to uplift this for 49 beta?

Comment 21

[[:Towkir] Ahmed]

Comment on attachment 8766506 [details] [diff] [review]
fixed_label_vertical_alignment.patch

As this is a small UI change, I would say "Yes"

Approval Request Comment
[Feature/regressing bug #]: 1246514
[User impact if declined]: No major impact, small UI modification just with a css change.
[Describe test coverage new/current, TreeHerder]: No new automated test, manually tested and landed in nightly for one month without regression.
[Risks and why]: There is no risks actually
[String/UUID change made/needed]:

Comment 22

[Gerry Chang [:gchang]]

Hi :Towkir,
The patch is already in 50 aurora. You should uplift this to 49 beta.

Comment 23

[[:Towkir] Ahmed]

Comment on attachment 8766506 [details] [diff] [review]
fixed_label_vertical_alignment.patch

Oops, sorry about that.
Requesting approval for 49 beta:

Approval Request Comment
[Feature/regressing bug #]: 1246514
[User impact if declined]: No major impact, small UI modification just with a css change.
[Describe test coverage new/current, TreeHerder]: No new automated test, manually tested and landed in nightly for one month without regression.
[Risks and why]: There is no risks actually
[String/UUID change made/needed]: None

Comment 24

[Gerry Chang [:gchang]]

Comment on attachment 8766506 [details] [diff] [review]
fixed_label_vertical_alignment.patch

Review of attachment 8766506 [details] [diff] [review]:
-----------------------------------------------------------------

This patch fixes a UI regression. Take it in 49 beta. Should be in 49 beta 5.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a90a1d791c7d