Closed Bug 1266162 Opened 8 years ago Closed 8 years ago

java.lang.IllegalStateException: History visits count (for guid=CZpqH6hMtjOm) was less than base number of visit: 32 at org.mozilla.gecko.db.BrowserDatabaseHelper.getNumberOfVisitsToSynthesize(BrowserDatabaseHelper.java)

Categories

(Firefox for Android Graveyard :: Data Providers, defect)

defect
Not set
normal

Tracking

(firefox48 fixed, fennec48+)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed
fennec 48+ ---

People

(Reporter: Grisha, Assigned: Grisha)

References

Details

Crash Data

Attachments

(1 file)

Don't throw during initial migration when number of visits for a given history item in history extensions db is more than a number stored in the VISITS column for that history item.
Sync is vast and could be strange, so let's allow for some weirdness in numbers and recover gracefully.

Review commit: https://reviewboard.mozilla.org/r/47763/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47763/
Attachment #8743447 - Flags: review?(gkruglov)
Comment on attachment 8743447 [details]
MozReview Request: Bug 1266162 - Don't throw during migration upon encountering a strange visits count r?grisha

https://reviewboard.mozilla.org/r/47763/#review44555
Attachment #8743447 - Flags: review?(gkruglov) → review+
https://hg.mozilla.org/integration/fx-team/rev/a4d77316a361dc337c167c5cad3fc943e0f6a844
Bug 1266162 - Don't throw during migration upon encountering a strange visits count r=grisha
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
It may seem like a formality, but you should request peer review on any change you land, even if it's pretty small.
tracking-fennec: --- → 48+
Crash Signature: [@ java.lang.IllegalStateException: History visits count (for guid=-5NFDZOTl0tL) was less than base number of visit: 1 at org.mozilla.gecko.db.BrowserDatabaseHelper.getNumberOfVisitsToSynthesize(BrowserDatabaseHelper.java)] [@ java.lang.IllegalStateExcep…
Blocks: 1046709
https://hg.mozilla.org/mozilla-central/rev/a4d77316a361
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.