Closed Bug 1266180 Opened 8 years ago Closed 8 years ago

Port unboxed object getprop stub to CacheIR

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch
20.18 KB, patch
efaust
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
I wrote this a while ago, before I got sidetracked, but forgot to post it.

 8 files changed, 81 insertions(+), 145 deletions(-)
Attachment #8743445 - Flags: review?(efaustbmo)
Comment on attachment 8743445 [details] [diff] [review]
Patch

Review of attachment 8743445 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/BaselineCacheIR.cpp
@@ +858,5 @@
> +    if (fieldType == JSVAL_TYPE_OBJECT)
> +        emitEnterTypeMonitorIC();
> +    else
> +        emitReturnFromIC();
> +    return true;

nit: vertical whitespace before |return true|
Attachment #8743445 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/bd49d27ea04e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.