Closed
Bug 1266180
Opened 9 years ago
Closed 9 years ago
Port unboxed object getprop stub to CacheIR
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
20.18 KB,
patch
|
efaust
:
review+
|
Details | Diff | Splinter Review |
I wrote this a while ago, before I got sidetracked, but forgot to post it.
8 files changed, 81 insertions(+), 145 deletions(-)
Attachment #8743445 -
Flags: review?(efaustbmo)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8743445 [details] [diff] [review]
Patch
Review of attachment 8743445 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jit/BaselineCacheIR.cpp
@@ +858,5 @@
> + if (fieldType == JSVAL_TYPE_OBJECT)
> + emitEnterTypeMonitorIC();
> + else
> + emitReturnFromIC();
> + return true;
nit: vertical whitespace before |return true|
Attachment #8743445 -
Flags: review?(efaustbmo) → review+
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•