1266185 - Add ability to deploy to Deis infra from private repo and add basic auth

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Paul [:pmac] McLanahan]

We need the ability to add basic auth to demo instances and to deploy said instances based on code in the private bedrock fork for instance where we can't release the code for a feature until it's ready for production.

Comment 1

[Paul [:pmac] McLanahan]

Writing a middleware to do the basic auth that is enabled whenever an env var exists with a "username:password" value should be pretty easy (e.g. "BASIC_AUTH_CREDS='thedude:thewalrus'"). The middleware code would then be a simplification of https://www.djangosnippets.org/snippets/243/.

Deploying from the private repo is a different matter. Not sure about that yet.

Comment 2

[Jennifer Bertsch [:jbertsch]]

Hi-

Is this work for Josh or Pmac to complete?

What is the level of priority?

thx
Jen

Comment 3

[Paul [:pmac] McLanahan]

The priority is whatever the priority of getting a demo for the blocked bugs :) I've got a PR in for the basic auth thing from comment #1, but I'm not sure yet about the deployment from private repo bit.

Comment 4

[Paul [:pmac] McLanahan]

Attachment: PR to add optional basic auth for private demos

Comment 5

[Josh Mize [:jgmize]]

This should not block bug 1266228 as the legacy demo environments have not been decommissioned and can be used for deploying password protected content from the private repos.  Enabling deploys to Deis from the private repo via circleci and/or jenkins won't be too difficult, but as long as the legacy demo deployments continue working this should be a relatively low priority IMO.

Comment 6

[Jennifer Bertsch [:jbertsch]]

Is this done per https://bugzilla.mozilla.org/show_bug.cgi?id=1265912#c3 ?

Comment 7

[Paul [:pmac] McLanahan]

No. That demo is on the old architecture. We still need to do some work to be able to deploy to AWS from the private repo.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/78bb8d5464fb6f6914f2890b3d8859f1d1a417fb
Bug 1266185: Add the ability to enable basic auth

Setting BASIC_AUTH_CREDS environment variable
will now protect the entire site with that username
and password. Value of the variable must be colon separated
username and password (e.g. "theuser:thepass").

https://github.com/mozilla/bedrock/commit/03645d471d9e14b26e8605a07356c72af8247076
Merge pull request #4077 from pmclanahan/add-basic-auth-for-demos-1266185

Bug 1266185: Add the ability to enable basic auth

Comment 9

[Josh Mize [:jgmize]]

Jenkins is automatically deploying from the demo__2 branch on the private repo to the bedrock-private-demo app on the us-west Deis cluster, and www-demo2.allizom.org is mapped to that app.