1266244 - Make mozreviewbots tests pass

Status: RESOLVED FIXED

(MozReview Graveyard :: Bots, defect)

Description

[Steven MacLeod [:smacleod]]

The mozreviewbots tests haven't been properly updated, and tests requiring eslint aren't conditionally skipped if it's not installed.

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: MozReview Request: mozreviewbots: add an eslint requirement for test-eslintbot (Bug 1266244). r?gps

The test-eslintbot.t test is now skipped if the eslint executable is not
on the PATH. We do not attempt to install eslint as part of creating the
test environment, I'm considering that out of scope for this change.

Review commit: https://reviewboard.mozilla.org/r/47901/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47901/

Comment 2

[Steven MacLeod [:smacleod]]

Attachment: MozReview Request: mozreviewbots: add author output to tests (Bug 1266244). r?glob

Some of the recent changes to MozReview missed updating the
mozreviewbots tests. The tests should now pass after this change.

Review commit: https://reviewboard.mozilla.org/r/47903/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47903/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8743595 [details]
MozReview Request: mozreviewbots: add an eslint requirement for test-eslintbot (Bug 1266244). r?gps

https://reviewboard.mozilla.org/r/47901/#review44635

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8743596 [details]
MozReview Request: mozreviewbots: add author output to tests (Bug 1266244). r?glob

https://reviewboard.mozilla.org/r/47903/#review44637

Comment 5

[Steven MacLeod [:smacleod]]

Comment on attachment 8743596 [details]
MozReview Request: mozreviewbots: add author output to tests (Bug 1266244). r?glob

:gps stole it