Make mozreviewbots tests pass

RESOLVED FIXED

Status

MozReview
Bots
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: smacleod, Assigned: smacleod)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
The mozreviewbots tests haven't been properly updated, and tests requiring eslint aren't conditionally skipped if it's not installed.
(Assignee)

Comment 1

2 years ago
Created attachment 8743595 [details]
MozReview Request: mozreviewbots: add an eslint requirement for test-eslintbot (Bug 1266244). r?gps

The test-eslintbot.t test is now skipped if the eslint executable is not
on the PATH. We do not attempt to install eslint as part of creating the
test environment, I'm considering that out of scope for this change.

Review commit: https://reviewboard.mozilla.org/r/47901/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47901/
Attachment #8743595 - Flags: review?(gps)
Attachment #8743596 - Flags: review?(glob)
(Assignee)

Comment 2

2 years ago
Created attachment 8743596 [details]
MozReview Request: mozreviewbots: add author output to tests (Bug 1266244). r?glob

Some of the recent changes to MozReview missed updating the
mozreviewbots tests. The tests should now pass after this change.

Review commit: https://reviewboard.mozilla.org/r/47903/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47903/

Comment 3

2 years ago
Comment on attachment 8743595 [details]
MozReview Request: mozreviewbots: add an eslint requirement for test-eslintbot (Bug 1266244). r?gps

https://reviewboard.mozilla.org/r/47901/#review44635
Attachment #8743595 - Flags: review?(gps) → review+

Comment 4

2 years ago
Comment on attachment 8743596 [details]
MozReview Request: mozreviewbots: add author output to tests (Bug 1266244). r?glob

https://reviewboard.mozilla.org/r/47903/#review44637
Attachment #8743596 - Flags: review+
(Assignee)

Comment 5

2 years ago
Comment on attachment 8743596 [details]
MozReview Request: mozreviewbots: add author output to tests (Bug 1266244). r?glob

:gps stole it
Attachment #8743596 - Flags: review?(glob)
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.