Closed
Bug 1266250
Opened 9 years ago
Closed 9 years ago
[css-grid] Add back the grid-template shorthand
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(2 files)
|
18.12 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
|
39.11 KB,
patch
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•9 years ago
|
||
This reverts the fix in bug 1253529. It applied cleanly, with one exception:
layout/style/nsCSSPropList.h because the list of properties is now
alphabetically sorted 'grid-template' should be inserted later in the file.
You only need to look at that file really.
Attachment #8743612 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Reverts the test changes. The Grid reftests pass locally so I don't think
I'll waste Try resources on this one.
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8743612 [details] [diff] [review]
part 1
Review of attachment 8743612 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks! Only looked at nsCSSPropList, as suggested. Sorting looks good there.
Attachment #8743612 -
Flags: review?(dholbert) → review+
|
||
Updated•9 years ago
|
Keywords: dev-doc-needed
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b24d0d66855a
https://hg.mozilla.org/mozilla-central/rev/497ba59de864
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
|
||
Updated•9 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•