Closed Bug 1266250 Opened 3 years ago Closed 3 years ago

[css-grid] Add back the grid-template shorthand

Categories

(Core :: CSS Parsing and Computation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

Attachments

(2 files)

Attached patch part 1Splinter Review
This reverts the fix in bug 1253529.  It applied cleanly, with one exception:
layout/style/nsCSSPropList.h because the list of properties is now
alphabetically sorted 'grid-template' should be inserted later in the file.
You only need to look at that file really.
Attachment #8743612 - Flags: review?(dholbert)
Attached patch part 2Splinter Review
Reverts the test changes.  The Grid reftests pass locally so I don't think
I'll waste Try resources on this one.
Comment on attachment 8743612 [details] [diff] [review]
part 1

Review of attachment 8743612 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Only looked at nsCSSPropList, as suggested.  Sorting looks good there.
Attachment #8743612 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/b24d0d66855a
https://hg.mozilla.org/mozilla-central/rev/497ba59de864
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.