Closed Bug 1266273 Opened 7 years ago Closed 7 years ago

Change type of ComputedTimingProperties.progress from unrestricted double? to double?

Categories

(Core :: DOM: Animation, defect)

Product:
Core
Component:
DOM: Animation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: birtles, Assigned: birtles)

Details

Attachments

(1 file)

Change type of ComputedTimingProperties.progress from unrestricted double? to double?
1.38 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
The spec has changed the type of this dictionary because it doesn't seem like there are any cases where this will be +/-Infinity or NaN:

  https://github.com/w3c/web-animations/commit/df138ee1314da46c6d671d7e406433c3e675ee61

Bug 1266257 adds an assertion that the progress is finite before we set it (specifically, the very end of the first patch in that series) and it doesn't seem to have failed in any of our automated tests so it seems like this change is ok.
Comment on attachment 8743642 [details] [diff] [review]
Change type of ComputedTimingProperties.progress from unrestricted double? to double?

r=me
Attachment #8743642 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/3ad1be09eddb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.