Change type of ComputedTimingProperties.progress from unrestricted double? to double?

RESOLVED FIXED in Firefox 48

Status

()

Core
DOM: Animation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: birtles, Assigned: birtles)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The spec has changed the type of this dictionary because it doesn't seem like there are any cases where this will be +/-Infinity or NaN:

  https://github.com/w3c/web-animations/commit/df138ee1314da46c6d671d7e406433c3e675ee61

Bug 1266257 adds an assertion that the progress is finite before we set it (specifically, the very end of the first patch in that series) and it doesn't seem to have failed in any of our automated tests so it seems like this change is ok.
(Assignee)

Comment 1

2 years ago
Created attachment 8743642 [details] [diff] [review]
Change type of ComputedTimingProperties.progress from unrestricted double? to double?

To reflect updates to the spec: https://github.com/w3c/web-animations/commit/df138ee1314da46c6d671d7e406433c3e675ee61

MozReview-Commit-ID: 525eLGCK4tl
Attachment #8743642 - Flags: review?(bzbarsky)
Comment on attachment 8743642 [details] [diff] [review]
Change type of ComputedTimingProperties.progress from unrestricted double? to double?

r=me
Attachment #8743642 - Flags: review?(bzbarsky) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ad1be09eddb

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3ad1be09eddb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.