Scroll-linked changes to the "margin" shorthand property aren't detected

RESOLVED FIXED in Firefox 48

Status

()

Core
Layout
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mstange, Assigned: kats)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The list at nsDOMCSSDeclaration::SetPropertyValue has the properties margin-left, margin-top, margin-right and margin-bottom. However, it does not contain the margin shorthand, nor the margin-{block,inline}-{start,end} properties.

Those properties should be added so that we can detect scroll-linked effects that change them.
Assignee: nobody → bugmail.mozilla
Created attachment 8743904 [details]
MozReview Request: Bug 1266288 - Track changes to all margin properties for scroll-linked effects. r?mstange

Review commit: https://reviewboard.mozilla.org/r/48177/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48177/
Attachment #8743904 - Flags: review?(mstange)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8743904 [details]
MozReview Request: Bug 1266288 - Track changes to all margin properties for scroll-linked effects. r?mstange

https://reviewboard.mozilla.org/r/48177/#review44885
Attachment #8743904 - Flags: review?(mstange) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9e5cdc2e73c4
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.