Closed Bug 1266293 Opened 8 years ago Closed 8 years ago

Remove unnecessary compiler version check and stdint polyfill for MSVS 2010 in webrtc/signaling/

Categories

(Core :: WebRTC: Signaling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- wontfix
firefox48 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(1 file)

Now that we no longer support MSVS 2010 (_MSC_VER == 1600), we can remove this compiler version check and stdint.h polyfill. Our supported MSVS and MinGW versions always have stdint.h.

media/webrtc/signaling/src/sdp/sipcc/cpr_win_types.h:45:#if _MSC_VER >= 1600
Attachment #8743657 - Flags: review?(adam)
Comment on attachment 8743657 [details] [diff] [review]
remove-stdint-polyfill.patch

Review of attachment 8743657 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM (assuming everything still compiles)
Attachment #8743657 - Flags: review?(adam) → review+
Thanks! My tryserver build was green with VS 2015, though I haven't tested VS 2013 (which we try to support but is not our official MSVS version).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3201e28f815a43f44394d047711649e3a82ed9fe
https://hg.mozilla.org/mozilla-central/rev/b2cb9942d434
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.