Closed
Bug 1266304
Opened 8 years ago
Closed 8 years ago
Merge MediaDecoderReader::AudioDataPromise and MediaDecoderReader::VideoDataPromise
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(2 files)
They are typedeffed from the same thing. We can merge them into one type which would allow us to merge functions that only differ in {Audio,Video}DataPromise.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jwwang
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48313/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48313/
Attachment #8744146 -
Flags: review?(tkuo)
Attachment #8744147 -
Flags: review?(tkuo)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48315/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48315/
Comment 3•8 years ago
|
||
Comment on attachment 8744146 [details] MozReview Request: Bug 1266304. Part 1 - Merge MediaDecoderReader::AudioDataPromise and MediaDecoderReader::VideoDataPromise. r=kaku. https://reviewboard.mozilla.org/r/48313/#review45105
Attachment #8744146 -
Flags: review?(tkuo) → review+
Updated•8 years ago
|
Attachment #8744147 -
Flags: review?(tkuo) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8744147 [details] MozReview Request: Bug 1266304. Part 2 - remove unnecessary template parameters. r=kaku. https://reviewboard.mozilla.org/r/48315/#review45107
Assignee | ||
Comment 5•8 years ago
|
||
Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a8c3d77911d https://hg.mozilla.org/integration/mozilla-inbound/rev/b4d0ef7a0f1e
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1a8c3d77911d https://hg.mozilla.org/mozilla-central/rev/b4d0ef7a0f1e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•