STR: $ ./mach eslint --setup $ echo ",syntaxerror," >> devtools/client/aboutdebugging/components/worker-target.js $ ./mach eslint devtools/ Expected: - eslint recurses into every sub-directory and catches at least the syntax error Actual: - eslint seems to skip "devtools/" because it's a directory, and says "No errors encountered". Workaround: $ ./mach eslint devtools/client/aboutdebugging/components/* # works, but is not helpful
Pinging some people who may be able to help with this.
This works fine for me using fish on OSX but it depends on your console app. The key thing is that ** should be set... just google globstar. Seems to be an age-old eslint issue.
Seems to work for me too on mac and windows. I don't think I've ever encountered errors where eslint was not recursing into sub directories. I found this related issue: https://github.com/eslint/eslint/issues/1663
Well, this problem stopped reproducing after a few updates and `./mach eslint --setup` calls, not sure what changed exactly. Alex, does it still reproduce on your side?
Still reproduces even after eslint --setup. ./mach eslint devtools/client/aboutdebugging/components/worker-target.js reports an error, whereas ./mach eslint devtools/ doesn't -v argument doesn't help. Is there a magic option to help debugging that?
Note that I just ran eslint --setup once today: Installing eslint using "/usr/bin/npm install email@example.com -g"... - Installing eslint-plugin-mozilla using "/usr/bin/npm link"... Installing eslint-plugin-html using "/usr/bin/npm install firstname.lastname@example.org -g"... Installing eslint-plugin-react using "/usr/bin/npm install email@example.com -g"... ESLint and approved plugins installed successfully!
(In reply to Alexandre Poirot [:ochameau] from comment #6) > Note that I just ran eslint --setup once today: > Installing eslint using "/usr/bin/npm install firstname.lastname@example.org -g"... > - > Installing eslint-plugin-mozilla using "/usr/bin/npm link"... > > Installing eslint-plugin-html using "/usr/bin/npm install > email@example.com -g"... > > Installing eslint-plugin-react using "/usr/bin/npm install > firstname.lastname@example.org -g"... > > ESLint and approved plugins installed successfully! Does this mean the problem is now fixed for you? Or is it still a problem even after the upgrades?
Still broken even if eslint --setup seems to be happy of itself.
Ok. So it was because of an outdated version of eslint being in my path. eslint -setup works fine and updates it correctly, but I had another version that took the precedance over npm one and wasn't updating. I think it will be better with bug 1271706, by warning about outdated versions.