1266395 - window.frameElement return null not only in top context

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: API: DOM, defect, P5)

Description

[Georgiy Ivankin]

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: unspecified
 Technical Contact: 

:: Details

MDN currently says:

Returns the element (such as <iframe> or <object>) in which the window is embedded, or null if the window is top-level.

But actually null is also returned if the container's document does not have the same effective script origin. See http://www.w3c-test.org/html/browsers/windows/nested-browsing-contexts/frameElement.sub.html (test 3) and http://w3c.github.io/html/browsers.html#navigating-nested-browsing-contexts-in-the-dom

Comment 1

[kshitija]

I would like to work on this bug. Can you assign it to me?

Comment 2

[Eric Shepherd [:sheppy]]

Assigned! To be clear though, you don't need the bug assigned to you in order to work on it. Just do it and post a comment when it's done. :)

Comment 3

[kshitija]

What changes I will have to make and where?

Comment 4

[kshitija]

Can I make changes directly on MDN and paste the link here for review or is there any other way to do it? Please guide me.. I am new to Mozilla group

Comment 5

[Eric Shepherd [:sheppy]]

(In reply to kshitija from comment #4)
> Can I make changes directly on MDN and paste the link here for review or is
> there any other way to do it? Please guide me.. I am new to Mozilla group

Just click the edit button on MDN and when you've finished editing, save your changes. Editing on MDN is done right on the site, in place, and your changes will be live as soon as you save. If you'd like a review, please feel free to follow up on this bug and let us know you'd like someone to take a look at what you've done.

If you're really, really uncomfortable posting changes yourself, you can attach them to a bug, but it doesn't work as smoothly usually, so it's a "better than nothing" solution. :)

Looking forward to seeing what you do!

Comment 6

[kshitija]

(In reply to Eric Shepherd [:sheppy] from comment #5)
> (In reply to kshitija from comment #4)
> > Can I make changes directly on MDN and paste the link here for review or is
> > there any other way to do it? Please guide me.. I am new to Mozilla group
> 
> Just click the edit button on MDN and when you've finished editing, save
> your changes. Editing on MDN is done right on the site, in place, and your
> changes will be live as soon as you save. If you'd like a review, please
> feel free to follow up on this bug and let us know you'd like someone to
> take a look at what you've done.
> 
> If you're really, really uncomfortable posting changes yourself, you can
> attach them to a bug, but it doesn't work as smoothly usually, so it's a
> "better than nothing" solution. :)
> 
> Looking forward to seeing what you do!

I have done the necessary changes and published it. If you feel its correct, resolve this bug.
Here is the link :
https://developer.mozilla.org/en-US/docs/Web/API/Window/frameElement

Comment 7

[Eric Shepherd [:sheppy]]

Looks good - I did a little copy editing on the page in general and updated it to match our latest style guide (it hadn't been done yet), and all's well. Thank you!

Comment 8

[kshitija]

Thank you