1266396 - Make TextureClient more robust against racy shutdown situations

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

As discussed with Bas, Jamie and Edwin, the plan is to protect TextureClient's methods that access mData or mActor with a mutex and hold on to that mutex while the TextureData is locked so that shutdown cannot race with some other thread reading from a texture.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Lock ALL THE THINGS.

I ended up putting the lock on the IPDL actor to reduce the likelihood of AsTextureClient() racing with the destruction of a texture from another thread. It's not entirely race-free however, but removing the few cycles that constitute that race a lot of work so I'd rather we do it as a followup considering this patch should improve the situation significantly.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/744c91c9c803

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/744c91c9c803