1266401 - stop constructing temporary strings in Android's appshell

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Nathan Froyd [:froydnj]]

We don't have to construct temporary strings to get at the raw
characters of a string.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: stop constructing temporary strings in Android's appshell

I guess we could also do this by converting Characters/CharactersExtra/Data to
return nsString& instead...whichever you like.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8743844 [details] [diff] [review]
stop constructing temporary strings in Android's appshell

Review of attachment 8743844 [details] [diff] [review]:
-----------------------------------------------------------------

nice, thanks!

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Nathan Froyd [:froydnj] from comment #1)
> Created attachment 8743844 [details] [diff] [review]
> stop constructing temporary strings in Android's appshell
> 
> I guess we could also do this by converting Characters/CharactersExtra/Data
> to
> return nsString& instead...whichever you like.

Yeah, maybe that would be better? I don't have strong feelings. I don't think the BeginReading() API is very intuitive, though.

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: stop constructing temporary strings in Android's appshell

Updated patch with changed types for the accessors and s/BeginReading/get/ as
appropriate.  Assuming I can carryover review for that one.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/abadd42a8e35

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/abadd42a8e35