stop constructing temporary strings in Android's appshell

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We don't have to construct temporary strings to get at the raw
characters of a string.
Created attachment 8743844 [details] [diff] [review]
stop constructing temporary strings in Android's appshell

I guess we could also do this by converting Characters/CharactersExtra/Data to
return nsString& instead...whichever you like.
Attachment #8743844 - Flags: review?(snorp)
Comment on attachment 8743844 [details] [diff] [review]
stop constructing temporary strings in Android's appshell

Review of attachment 8743844 [details] [diff] [review]:
-----------------------------------------------------------------

nice, thanks!
Attachment #8743844 - Flags: review?(snorp) → review+
(In reply to Nathan Froyd [:froydnj] from comment #1)
> Created attachment 8743844 [details] [diff] [review]
> stop constructing temporary strings in Android's appshell
> 
> I guess we could also do this by converting Characters/CharactersExtra/Data
> to
> return nsString& instead...whichever you like.

Yeah, maybe that would be better? I don't have strong feelings. I don't think the BeginReading() API is very intuitive, though.
Created attachment 8743868 [details] [diff] [review]
stop constructing temporary strings in Android's appshell

Updated patch with changed types for the accessors and s/BeginReading/get/ as
appropriate.  Assuming I can carryover review for that one.
Attachment #8743868 - Flags: review+
Attachment #8743844 - Attachment is obsolete: true

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/abadd42a8e35
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.