Closed
Bug 1266401
Opened 8 years ago
Closed 8 years ago
stop constructing temporary strings in Android's appshell
Categories
(Core Graveyard :: Widget: Android, defect)
Core Graveyard
Widget: Android
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file, 1 obsolete file)
6.66 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
We don't have to construct temporary strings to get at the raw characters of a string.
Assignee | ||
Comment 1•8 years ago
|
||
I guess we could also do this by converting Characters/CharactersExtra/Data to return nsString& instead...whichever you like.
Attachment #8743844 -
Flags: review?(snorp)
Comment on attachment 8743844 [details] [diff] [review] stop constructing temporary strings in Android's appshell Review of attachment 8743844 [details] [diff] [review]: ----------------------------------------------------------------- nice, thanks!
Attachment #8743844 -
Flags: review?(snorp) → review+
(In reply to Nathan Froyd [:froydnj] from comment #1) > Created attachment 8743844 [details] [diff] [review] > stop constructing temporary strings in Android's appshell > > I guess we could also do this by converting Characters/CharactersExtra/Data > to > return nsString& instead...whichever you like. Yeah, maybe that would be better? I don't have strong feelings. I don't think the BeginReading() API is very intuitive, though.
Assignee | ||
Comment 4•8 years ago
|
||
Updated patch with changed types for the accessors and s/BeginReading/get/ as appropriate. Assuming I can carryover review for that one.
Attachment #8743868 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Attachment #8743844 -
Attachment is obsolete: true
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/abadd42a8e35
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•