Closed Bug 1266405 Opened 4 years ago Closed 4 years ago

AudioBufferSourceNode::CopyFromBuffer could borrow unaligned buffers

Categories

(Core :: Web Audio, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(1 file)

We need to check for alignment before we just borrow buffers from the input.

This was part of the original patch for Bug 877662 but I missed picking it up due to code reorganization.
Comment on attachment 8743849 [details]
MozReview Request: Bug 1266405 - AudioBufferSourceNode::CopyFromBuffer should not borrow unaligned buffers; r?padenot

https://reviewboard.mozilla.org/r/48071/#review44853
Attachment #8743849 - Flags: review?(padenot) → review+
https://hg.mozilla.org/mozilla-central/rev/a86e8abdc7db
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.