1266430 - Support offsets in DrawTargetD2D1::CopySurface when using a DataSourceSurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: MozReview Request: Bug 1266430: Support offsets in DrawTargetD2D1::CopySurface when using PartialUploading. r=jrmuizel

Review commit: https://reviewboard.mozilla.org/r/48169/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48169/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8743889 [details]
MozReview Request: Bug 1266430: Support offsets in DrawTargetD2D1::CopySurface when using PartialUploading. r=jrmuizel

https://reviewboard.mozilla.org/r/48169/#review45377

::: gfx/2d/DrawTargetD2D1.cpp:380
(Diff revision 1)
> -    gfxDebug() << *this << ": At this point complex partial uploads are not supported for CopySurface.";
> +    gfxDebug() << *this << ": At this point scaled partial uploads are not supported for CopySurface.";
>      return;
>    }
>  
> +  IntRect sourceRect = aSourceRect;
> +  sourceRect.x += (aDestination.x - aSourceRect.x) - mat._31;

Doesn't mat._31 == (aDestination.x - aSourceRect.x)?

Comment 3

[Bas Schouten (:bas.schouten)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Comment on attachment 8743889 [details]
> MozReview Request: Bug 1266430: Support offsets in
> DrawTargetD2D1::CopySurface when using PartialUploading. r=jrmuizel
> 
> https://reviewboard.mozilla.org/r/48169/#review45377
> 
> ::: gfx/2d/DrawTargetD2D1.cpp:380
> (Diff revision 1)
> > -    gfxDebug() << *this << ": At this point complex partial uploads are not supported for CopySurface.";
> > +    gfxDebug() << *this << ": At this point scaled partial uploads are not supported for CopySurface.";
> >      return;
> >    }
> >  
> > +  IntRect sourceRect = aSourceRect;
> > +  sourceRect.x += (aDestination.x - aSourceRect.x) - mat._31;
> 
> Doesn't mat._31 == (aDestination.x - aSourceRect.x)?

The partial upload function adjusts the matrix for the offset it might have uploaded from, this causes that offset to be taken into account.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8743889 [details]
MozReview Request: Bug 1266430: Support offsets in DrawTargetD2D1::CopySurface when using PartialUploading. r=jrmuizel

https://reviewboard.mozilla.org/r/48169/#review45607

Ah screwed over by C++'s implicit reference taking syntax. I wouldn't mind a comment about GetImageSurface modify mat.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f27d845244c5

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f27d845244c5