Closed Bug 1266440 Opened 4 years ago Closed 3 years ago

Remove crash annotation IPCExtraSystemError once bug 1258317 is fixed

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox47 --- wontfix
firefox48 + wontfix
firefox49 + fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: jimm, Assigned: cyu)

References

Details

(Whiteboard: btpp-followup-2016-05-21)

Attachments

(1 file)

[Tracking Requested - why for this release]:
Hooking this up to 48 so we don't lose it. We can push this out as needed. Eventually though we want this removed.

https://bugzilla.mozilla.org/show_bug.cgi?id=1258317#c44
Whiteboard: btpp-followup-2016-05-21
bug 1258317 is fixed for 48 now. Want to uplift this to 48?
Flags: needinfo?(jmathies)
Oh, there isn't a patch. Is there anything to do here?
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #2)
> Oh, there isn't a patch. Is there anything to do here?

Don't want to close this yet. It's for tracking the removal of some diagnostic code we landed to debug bug 1258317.
Flags: needinfo?(jmathies)
Flags: needinfo?(cyu)
(In reply to Cervantes Yu [:cyu] [:cervantes] from comment #4)
> Created attachment 8763832 [details]
> Bug 1266440 - Remove diagnostic funciton
> mozilla::ipc::AnnotateProcessInformation() that contains PII.
> 
The call site was removed in bug 1271601. This patch removes the definition.
Assignee: nobody → cyu
Flags: needinfo?(cyu)
Comment on attachment 8763832 [details]
Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59946/diff/1-2/
Attachment #8763832 - Flags: review?(gkrizsanits)
Attachment #8763832 - Flags: review?(gkrizsanits) → review+
Comment on attachment 8763832 [details]
Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII.

https://reviewboard.mozilla.org/r/59946/#review65318
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c16cea7afa66c59d18a6b88cfc95274599a1c7
Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII. r=krizsa
We will ship 48 with this crash, updating the flags
https://hg.mozilla.org/mozilla-central/rev/c0c16cea7afa
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment on attachment 8763832 [details]
Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII.

Approval Request Comment
[Feature/regressing bug #]: bug 1258317
[User impact if declined]: crash reports contain PII to users with access to the raw dump.
[Describe test coverage new/current, TreeHerder]: Patch landed/tested on central.
[Risks and why]: Pretty low. This patch only removes diagnostic code.
[String/UUID change made/needed]: None.
Attachment #8763832 - Flags: approval-mozilla-beta?
Comment on attachment 8763832 [details]
Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII.

OK, let's remove it, should be in 49 beta 3
Attachment #8763832 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Did this get landed for 50? I see landings on 51 and 49, but nothing for 50.
Flags: needinfo?(cyu)
It's in the current beta (50).
Flags: needinfo?(cyu)
Sorry, scratch comment #15. It's not in 50. I missed the request for aurora (now beta).  Sylvestre, can we make this into 50?
Flags: needinfo?(sledru)
Flags: needinfo?(rkothari)
(In reply to Cervantes Yu [:cyu] [:cervantes] from comment #16)
> Sorry, scratch comment #15. It's not in 50. I missed the request for aurora
> (now beta).  Sylvestre, can we make this into 50?

Yes, please go ahead and land it on m-b. 50 should have all the fixes that are in 49 + more. Hi KWierso, please go ahead and uplift.
Flags: needinfo?(sledru) → needinfo?(wkocher)
You need to log in before you can comment on or make changes to this bug.