Closed
Bug 1266440
Opened 8 years ago
Closed 8 years ago
Remove crash annotation IPCExtraSystemError once bug 1258317 is fixed
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: jimm, Assigned: cyu)
References
Details
(Whiteboard: btpp-followup-2016-05-21)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
gkrizsanits
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details |
[Tracking Requested - why for this release]: Hooking this up to 48 so we don't lose it. We can push this out as needed. Eventually though we want this removed. https://bugzilla.mozilla.org/show_bug.cgi?id=1258317#c44
Updated•8 years ago
|
Whiteboard: btpp-followup-2016-05-21
Comment 1•8 years ago
|
||
bug 1258317 is fixed for 48 now. Want to uplift this to 48?
Flags: needinfo?(jmathies)
Comment 2•8 years ago
|
||
Oh, there isn't a patch. Is there anything to do here?
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #2) > Oh, there isn't a patch. Is there anything to do here? Don't want to close this yet. It's for tracking the removal of some diagnostic code we landed to debug bug 1258317.
Flags: needinfo?(jmathies)
Reporter | ||
Updated•8 years ago
|
status-firefox47:
--- → affected
status-firefox49:
--- → affected
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(cyu)
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59946/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59946/
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Cervantes Yu [:cyu] [:cervantes] from comment #4) > Created attachment 8763832 [details] > Bug 1266440 - Remove diagnostic funciton > mozilla::ipc::AnnotateProcessInformation() that contains PII. > The call site was removed in bug 1271601. This patch removes the definition.
Assignee: nobody → cyu
Flags: needinfo?(cyu)
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8763832 [details] Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59946/diff/1-2/
Assignee | ||
Updated•8 years ago
|
Attachment #8763832 -
Flags: review?(gkrizsanits)
Updated•8 years ago
|
Attachment #8763832 -
Flags: review?(gkrizsanits) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8763832 [details] Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII. https://reviewboard.mozilla.org/r/59946/#review65318
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c16cea7afa66c59d18a6b88cfc95274599a1c7 Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII. r=krizsa
Comment 9•8 years ago
|
||
We will ship 48 with this crash, updating the flags
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c0c16cea7afa
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8763832 [details] Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII. Approval Request Comment [Feature/regressing bug #]: bug 1258317 [User impact if declined]: crash reports contain PII to users with access to the raw dump. [Describe test coverage new/current, TreeHerder]: Patch landed/tested on central. [Risks and why]: Pretty low. This patch only removes diagnostic code. [String/UUID change made/needed]: None.
Attachment #8763832 -
Flags: approval-mozilla-beta?
Comment 12•8 years ago
|
||
Comment on attachment 8763832 [details] Bug 1266440 - Remove diagnostic funciton mozilla::ipc::AnnotateProcessInformation() that contains PII. OK, let's remove it, should be in 49 beta 3
Attachment #8763832 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 13•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/b5ba20fc86c8
Did this get landed for 50? I see landings on 51 and 49, but nothing for 50.
Flags: needinfo?(cyu)
Assignee | ||
Comment 16•8 years ago
|
||
Sorry, scratch comment #15. It's not in 50. I missed the request for aurora (now beta). Sylvestre, can we make this into 50?
Flags: needinfo?(sledru)
Flags: needinfo?(rkothari)
status-firefox50:
--- → affected
Flags: needinfo?(rkothari)
(In reply to Cervantes Yu [:cyu] [:cervantes] from comment #16) > Sorry, scratch comment #15. It's not in 50. I missed the request for aurora > (now beta). Sylvestre, can we make this into 50? Yes, please go ahead and land it on m-b. 50 should have all the fixes that are in 49 + more. Hi KWierso, please go ahead and uplift.
Flags: needinfo?(sledru) → needinfo?(wkocher)
https://hg.mozilla.org/releases/mozilla-beta/rev/c03e51cec3b5f6b8821687c8db8be309727d5470
Flags: needinfo?(wkocher)
You need to log in
before you can comment on or make changes to this bug.
Description
•