Closed
Bug 1266513
Opened 8 years ago
Closed 8 years ago
Remove dead code from GetPluginPort
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
Details
Attachments
(1 file, 1 obsolete file)
1.49 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
nsPluginInstanceOwner::GetPluginPort has some dead code relating to NS_NATIVE_GRAPHIC on windowless plugins. It's confusing to see in DXR since it's very broken, so I'd like to remove it.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8743994 -
Flags: review?(jmathies)
Assignee | ||
Comment 2•8 years ago
|
||
More code removed.
Attachment #8743994 -
Attachment is obsolete: true
Attachment #8743994 -
Flags: review?(jmathies)
Attachment #8743997 -
Flags: review?(jmathies)
Comment 3•8 years ago
|
||
Comment on attachment 8743997 [details] [diff] [review] v2 Review of attachment 8743997 [details] [diff] [review]: ----------------------------------------------------------------- probably be good to push this to try for a mochitest test run just to be sure.
Attachment #8743997 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0c06056c7da
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b10037459c7a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•