Closed Bug 1266513 Opened 8 years ago Closed 8 years ago

Remove dead code from GetPluginPort

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: dvander, Assigned: dvander)

Details

Attachments

(1 file, 1 obsolete file)

nsPluginInstanceOwner::GetPluginPort has some dead code relating to NS_NATIVE_GRAPHIC on windowless plugins. It's confusing to see in DXR since it's very broken, so I'd like to remove it.
Attached patch patch (obsolete) — Splinter Review
Attachment #8743994 - Flags: review?(jmathies)
Attached patch v2Splinter Review
More code removed.
Attachment #8743994 - Attachment is obsolete: true
Attachment #8743994 - Flags: review?(jmathies)
Attachment #8743997 - Flags: review?(jmathies)
Comment on attachment 8743997 [details] [diff] [review]
v2

Review of attachment 8743997 [details] [diff] [review]:
-----------------------------------------------------------------

probably be good to push this to try for a mochitest test run just to be sure.
Attachment #8743997 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/b10037459c7a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.