Closed Bug 1266518 Opened 8 years ago Closed 8 years ago

add a new event message for AccSelChangeEvents

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file, 1 obsolete file)

For these events atk needs to know about the widget not the event target, and
the easiest way to support that is by adding a new event message that sends the
widget id.
Attachment #8743999 - Flags: review?(dbolter)
For these events atk needs to know about the widget not the event target, and
the easiest way to support that is by adding a new event message that sends the
widget id.
Attachment #8744014 - Flags: review?(dbolter)
Attachment #8743999 - Attachment is obsolete: true
Attachment #8743999 - Flags: review?(dbolter)
Comment on attachment 8744014 [details] [diff] [review]
add a new event message for AccSelChangeEvents

Review of attachment 8744014 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/Accessible.cpp
@@ +887,5 @@
> +        case nsIAccessibleEvent::EVENT_SELECTION:
> +        case nsIAccessibleEvent::EVENT_SELECTION_ADD:
> +        case nsIAccessibleEvent::EVENT_SELECTION_REMOVE: {
> +          AccSelChangeEvent* selEvent = downcast_accEvent(aEvent);
> +          uint64_t widgetID = selEvent->Widget()->IsDoc() ? 0 :

Widget() is guaranteed right?
Attachment #8744014 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/56dd2bd9e898
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: