Closed Bug 1266568 Opened 4 years ago Closed 4 years ago

Fix typo in “Highest” priority item id: |list_priotity_highest| -> |list_priority_highest|

Categories

(Thunderbird :: Message Compose Window, defect, trivial)

All
Unspecified
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 48.0

People

(Reporter: qeole, Assigned: qeole)

Details

Attachments

(1 file, 1 obsolete file)

In messagecompose.xul file, there is a typo in the |priorityMenu-button| menulist: for highest priority, the id is set to |list_priotity_highest| instead of |list_priority_highest|.

It does not seem to have any consequence though, since the ids of those items are not used (the ”value”s are used instead by PriorityMenySelect() in file MsgComposeCommands.js).

Still, I include a patch fixing the typo.
Attached patch bug1266568_patch_FixTypo (obsolete) — Splinter Review
@Magnus: Not sure who to assign review to, so I take the first name in the suggestion list :/
Assignee: nobody → qeole
Status: NEW → ASSIGNED
Attachment #8744071 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8744071 [details] [diff] [review]
bug1266568_patch_FixTypo

Review of attachment 8744071 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thx for the patch. r=mkmelin
Attachment #8744071 - Flags: review?(mkmelin+mozilla) → review+
Thanks Magnus!

Here's the final version of the patch, with reviewer's name appended to commit description. I'm asking for checkin.
Attachment #8744071 - Attachment is obsolete: true
Attachment #8744291 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/f3abd6bc5c74
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
If you want this fixed on the 45.x releases as well, please nominate for approval-comm-esr45.

Also, no need to post a new patch just for adding the reviewer to the commit message, this can be done easily by whoever is checking it in.
Comment on attachment 8744291 [details] [diff] [review]
8744071: bug1266568_patch_FixTypo

@rsx11m: thanks for the checkin!

(In reply to rsx11m from comment #5)
> If you want this fixed on the 45.x releases as well, please nominate for
> approval-comm-esr45.
OK, I do that.
> 
> Also, no need to post a new patch just for adding the reviewer to the commit
> message, this can be done easily by whoever is checking it in.
Thanks for the tip, I did not know that. My previous patches were more complex and I generally had the opportunity to add the reviewer's name between the general acceptance and the submission of the final version of the patch that would include some minor fixes.
Whatever, thanks, I will remember this!


[Approval Request Comment]
User impact if declined:             None. As far as I know, the typo had no impact whatsoever.
Testing completed (on c-c, etc.):    None (this is just a fix for a typo).
Risk to taking this patch (and alternatives if risky):   None, to the best of my knowledge.
Attachment #8744291 - Flags: approval-comm-esr45?
Comment on attachment 8744291 [details] [diff] [review]
8744071: bug1266568_patch_FixTypo

If this has no actual user impact, I don't see why we should push it to TB 45.
Attachment #8744291 - Flags: approval-comm-esr45? → approval-comm-esr45-
You need to log in before you can comment on or make changes to this bug.