1266568 - Fix typo in “Highest” priority item id: |list_priotity_highest| -> |list_priority_highest|

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Qeole]

In messagecompose.xul file, there is a typo in the |priorityMenu-button| menulist: for highest priority, the id is set to |list_priotity_highest| instead of |list_priority_highest|.

It does not seem to have any consequence though, since the ids of those items are not used (the ”value”s are used instead by PriorityMenySelect() in file MsgComposeCommands.js).

Still, I include a patch fixing the typo.

Comment 1

[Qeole]

Attachment: bug1266568_patch_FixTypo

@Magnus: Not sure who to assign review to, so I take the first name in the suggestion list :/

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8744071 [details] [diff] [review]
bug1266568_patch_FixTypo

Review of attachment 8744071 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thx for the patch. r=mkmelin

Comment 3

[Qeole]

Attachment: 8744071: bug1266568_patch_FixTypo

Thanks Magnus!

Here's the final version of the patch, with reviewer's name appended to commit description. I'm asking for checkin.

Comment 4

[rsx11m]

http://hg.mozilla.org/comm-central/rev/f3abd6bc5c74

Comment 5

[rsx11m]

If you want this fixed on the 45.x releases as well, please nominate for approval-comm-esr45.

Also, no need to post a new patch just for adding the reviewer to the commit message, this can be done easily by whoever is checking it in.

Comment 6

[Qeole]

Comment on attachment 8744291 [details] [diff] [review]
8744071: bug1266568_patch_FixTypo

@rsx11m: thanks for the checkin!

(In reply to rsx11m from comment #5)
> If you want this fixed on the 45.x releases as well, please nominate for
> approval-comm-esr45.
OK, I do that.
> 
> Also, no need to post a new patch just for adding the reviewer to the commit
> message, this can be done easily by whoever is checking it in.
Thanks for the tip, I did not know that. My previous patches were more complex and I generally had the opportunity to add the reviewer's name between the general acceptance and the submission of the final version of the patch that would include some minor fixes.
Whatever, thanks, I will remember this!


[Approval Request Comment]
User impact if declined:             None. As far as I know, the typo had no impact whatsoever.
Testing completed (on c-c, etc.):    None (this is just a fix for a typo).
Risk to taking this patch (and alternatives if risky):   None, to the best of my knowledge.

Comment 7

[Kent James (:rkent)]

Comment on attachment 8744291 [details] [diff] [review]
8744071: bug1266568_patch_FixTypo

If this has no actual user impact, I don't see why we should push it to TB 45.