1266569 - Remove the ChromeUtils binding from xpcom/io/Base64.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Lina Butler [:lina]]

Per Nathan's suggestion in https://bugzilla.mozilla.org/show_bug.cgi?id=1256488#c38, we should use XPCOM-specific enums instead of passing the dictionaries directly.

Comment 1

[jukaru]

Yesterday update Nightly 48 to 20160421 builds, Firefox not working. Always show Couldn't load XPCOM. Please fix.

Comment 2

[Lina Butler [:lina]]

Hi jukaru! I don't think this bug is related to your issue, since it was only merged a few hours ago. It's not in Nightly 20160421 or 20160422. I'm guessing you found this by searching for "xpcom" on Bugzilla?

I found this support thread that looks relevant to your error: https://support.mozilla.org/en-US/questions/1029239 Sadly, I think you'll need to uninstall and reinstall Firefox. Make sure you don't remove personal data when you uninstall!

If you're still having trouble, you can file a support ticket here: https://support.mozilla.org/en-US/questions/new/desktop/fix-problems Those folks can help you a lot better than I can. :-) Thanks!

Comment 3

[jukaru]

Maybe my bug is not related. Found title and joined. Sorry. This bug is always after update to builds 21 or maybe 22 april too. I use portable version Nightly from portableapps.com. I have several versions on HDD from march and april. Always after update to last version Firefox install update, but after this not loading.

Comment 4

[Lina Butler [:lina]]

Oh, I see. I'm really sorry you're having trouble. I don't know anything about Portable Apps, unfortunately. You could try asking on Mozilla Support, or this thread might help: http://portableapps.com/node/53914

Comment 5

[Lina Butler [:lina]]

Attachment: paddingPolicyEnums.patch

Is this what you were thinking, Nathan?

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8744397 [details] [diff] [review]
paddingPolicyEnums.patch

Review of attachment 8744397 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the change below.  Thanks for doing this!

::: dom/base/ChromeUtils.cpp
@@ +105,5 @@
> +      break;
> +
> +    default:
> +      aRv.Throw(NS_ERROR_INVALID_ARG);
> +      break;

I think we want to return here, rather than breaking out of the switch and continuing with the function, as otherwise we would use |paddingPolicy| without defining it?

Comment 7

[Lina Butler [:lina]]

(In reply to Nathan Froyd [:froydnj] from comment #6)
> I think we want to return here, rather than breaking out of the switch and
> continuing with the function, as otherwise we would use |paddingPolicy|
> without defining it?

Copy-pasta fail. Yup, I meant "return", not "break". :-)

Try push with the change: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad3cf551877e

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01d62c32ac21

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01d62c32ac21