Closed
Bug 1266573
Opened 8 years ago
Closed 8 years ago
Add the `JS::ubi::dumpPaths` debug utility
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file, 1 obsolete file)
3.38 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8744074 -
Flags: review?(jimb)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
I felt that this is a general enough debugging utility that others may want it as well and it should live in-tree. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fb8824187d9
Comment 3•8 years ago
|
||
Comment on attachment 8744074 [details] [diff] [review] Add the `JS::ubi::dumpPaths` debug utility Review of attachment 8744074 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/public/UbiNodeShortestPaths.h @@ +331,5 @@ > }; > > +#ifdef DEBUG > +JS_PUBLIC_API(void) > +dumpPaths(JSRuntime* rt, Node node, uint32_t maxNumPaths = 10); This deserves a helpful comment.
Attachment #8744074 -
Flags: review?(jimb) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8744074 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
You should post this to the mailing list when it lands. Just a link to the comment, and the sample output, will capture people's imagination.
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8deda08fc04b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•