Closed Bug 1266573 Opened 6 years ago Closed 6 years ago

Add the `JS::ubi::dumpPaths` debug utility

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
I felt that this is a general enough debugging utility that others may want it as well and it should live in-tree.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fb8824187d9
Comment on attachment 8744074 [details] [diff] [review]
Add the `JS::ubi::dumpPaths` debug utility

Review of attachment 8744074 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/public/UbiNodeShortestPaths.h
@@ +331,5 @@
>  };
>  
> +#ifdef DEBUG
> +JS_PUBLIC_API(void)
> +dumpPaths(JSRuntime* rt, Node node, uint32_t maxNumPaths = 10);

This deserves a helpful comment.
Attachment #8744074 - Flags: review?(jimb) → review+
Now with helpful comment.
Attachment #8744087 - Flags: review+
Attachment #8744074 - Attachment is obsolete: true
You should post this to the mailing list when it lands. Just a link to the comment, and the sample output, will capture people's imagination.
https://hg.mozilla.org/mozilla-central/rev/8deda08fc04b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.