1266648 - crash in nsHTMLEditor::SplitStyleAbovePoint

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-a9353322-463c-46da-87b1-c043b2160422.
=============================================================

This is a new crash that first appeared in Nightly 20160420030213. It's happened 7 times so far. It looks like it might be a null deref.

> 0 	xul.dll 	nsHTMLEditor::SplitStyleAbovePoint(nsCOMPtr<nsINode>*, int*, nsIAtom*, nsAString_internal const*, nsIContent**, nsIContent**) 	editor/libeditor/nsHTMLEditorStyle.cpp
> 1 	xul.dll 	nsHTMLEditRules::JoinBlocks(nsIContent&, nsIContent&, bool*) 	editor/libeditor/nsHTMLEditRules.cpp
> 2 	xul.dll 	nsHTMLEditRules::WillDeleteSelection(mozilla::dom::Selection*, short, short, bool*, bool*) 	editor/libeditor/nsHTMLEditRules.cpp
> 3 	xul.dll 	nsHTMLEditRules::WillDoAction(mozilla::dom::Selection*, nsRulesInfo*, bool*, bool*) 	editor/libeditor/nsHTMLEditRules.cpp
> 4 	xul.dll 	nsPlaintextEditor::DeleteSelection(short, short) 	editor/libeditor/nsPlaintextEditor.cpp
> 5 	xul.dll 	nsEditor::HandleKeyPressEvent(nsIDOMKeyEvent*) 	editor/libeditor/nsEditor.cpp
> 6 	xul.dll 	nsHTMLEditor::HandleKeyPressEvent(nsIDOMKeyEvent*) 	editor/libeditor/nsHTMLEditor.cpp
> 7 	xul.dll 	nsEditorEventListener::KeyPress(nsIDOMKeyEvent*) 	editor/libeditor/nsEditorEventListener.cpp
> 8 	xul.dll 	nsEditorEventListener::HandleEvent(nsIDOMEvent*) 	editor/libeditor/nsEditorEventListener.cpp

It might be related to bug 1190172, which touched this code recently.

Comment 1

[Nicholas Nethercote [inactive]]

Aryeh, can you please take a look?

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

This is because I changed an NS_ENSURE_TRUE to a MOZ_ASSERT.  If I were redoing these patches now, I probably wouldn't do that.  The fix is just to change it back.

Note: the patch seems to have been backed out for other reasons, so we just need to fix before relanding.

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Should be fixed in the new version of the patch: https://hg.mozilla.org/mozilla-central/rev/9c056080ee98#l3.68