Closed
Bug 1266659
Opened 8 years ago
Closed 8 years ago
[TV] Use a shared library to determine what the BACK key is on the remote control
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(blocking-b2g:2.6?)
RESOLVED
FIXED
| blocking-b2g | 2.6? |
People
(Reporter: lchang, Assigned: lchang)
References
Details
Attachments
(1 file)
On remote controls, the keycode (and keyname) of the BACK key varies from device to device. Using a shared library in Gaia to determine what the BACK key is enables us to easily adapt different devices.
|
||
Comment 1•8 years ago
|
||
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8744822 [details] [review] [gaia] luke-chang:1266659_tv_shared_back_key_define > mozilla-b2g:master Hi Yifan, May I ask you to review this patch, especially it touches lots of browser's code? Thanks a lot. Hi Sean, Would you mind taking a look at this patch as well? It would be better to have your confirmation about the changes related to the settings app.
Attachment #8744822 -
Flags: review?(yliao)
Attachment #8744822 -
Flags: feedback?(selee)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8744822 [details] [review] [gaia] luke-chang:1266659_tv_shared_back_key_define > mozilla-b2g:master LGTM! Thanks for the patch!
Attachment #8744822 -
Flags: feedback?(selee) → feedback+
|
|
||
Updated•8 years ago
|
Blocks: TV_Settings
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8744822 [details] [review] [gaia] luke-chang:1266659_tv_shared_back_key_define > mozilla-b2g:master Thank you!
Attachment #8744822 -
Flags: review?(yliao) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Yifan and Sean, Thanks a lot. landed on master: https://github.com/mozilla-b2g/gaia/commit/05a734fb3d6433044bd6bc3c78fda0d88ada5f4e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•