Closed
Bug 1266687
Opened 9 years ago
Closed 9 years ago
buildbot automation: clean up leftover tests_results
Categories
(NSS :: Test, defect)
NSS
Test
Tracking
(firefox48 affected)
RESOLVED
FIXED
3.24
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | affected |
People
(Reporter: KaiE, Unassigned)
Details
Attachments
(1 file)
|
1000 bytes,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
On of our windows builders was in a broken state, because automation scripts had assumed the tests_results are in a directory named localhost.1, but because there was a leftover directory from a previous run, the NSS test suite had decided to use directory localhost.2
The current build.sh assumes that the move_results() function gets always called to clean up, which not happen on unexpected interruptions.
Let's always clean up prior to starting the test suite.
|
Reporter | |
Comment 1•9 years ago
|
||
Attachment #8744258 -
Flags: review?(franziskuskiefer)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8744258 [details] [diff] [review]
1266687.patch
Review of attachment 8744258 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8744258 -
Flags: review?(franziskuskiefer) → review+
|
|
Reporter | |
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.24
You need to log in
before you can comment on or make changes to this bug.
Description
•