1266691 - Make menu have the same rounded corners as the menu toolbar when there are no toolbar items to display

Status: VERIFIED FIXED

(Firefox for iOS :: Menu and Toolbar, defect)

Description

[Emily Toop (:fluffyemily)]

When there are menu toolbar items to display, the menu has nice rounded corners. However, when there are no toolbar items, the toolbar does not display and the menu has square corners. 

Ensure that the menu displays with rounded corners regardless of whether or not the menu toolbar is being displayed.

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8744317 [details] [review]
Pull request

Left feedback on the PR

Comment 3

[Robin Andersen [:tecgirl]]

Comment on attachment 8744317 [details] [review]
Pull request

Same nit: the curve is also on the bottom.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8744317 [details] [review]
Pull request

Looks good! I've never heard of UIRectCorner before - really neat API.

Comment 5

[Emily Toop (:fluffyemily)]

:tecgirl

Comment 6

[Simon Basca [:SimonB]]

Tested on master d3c9de01.
The menu have the same rounded corners as the menu toolbar when there are no toolbar items to display.